Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

unique process_name in init handshake #1411

Open
Raynos opened this issue Dec 25, 2015 · 3 comments
Open

unique process_name in init handshake #1411

Raynos opened this issue Dec 25, 2015 · 3 comments

Comments

@Raynos
Copy link
Contributor

Raynos commented Dec 25, 2015

We currently have a "unique" process name in init handshake because we include the pid.

However on docker the pid is always 1. We should add some more unique-ness to the process name.

The use case here is defense against fd leak in hyperbahn. I want to implement a "maximum fd per process_name" since right now:

  'go-contact-solver[1]': 55164,

the contact-solver application has 5k fd per instance all under one bucket because all K instances have the same process_name.

cc @prashantv @breerly @jcorbin

@Raynos
Copy link
Contributor Author

Raynos commented Dec 25, 2015

Alternatively we could just add some new fields to the init headers like:

service_name
instance_name

Instead of using the process_name as a unique identifier of the remote.

@abhinav
Copy link
Contributor

abhinav commented Dec 28, 2015

Do we have actual critical logic based on the process name? https://github.com/uber/tchannel/blob/master/docs/protocol.md#headers says that it's used for logging. I was under the impression that's all it was for.

@Raynos
Copy link
Contributor Author

Raynos commented Dec 28, 2015

Not yet. As mentioned I want to implement a per process name limit on resources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants