Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment fails to be posted on linked pull-request that cannot be started #102

Closed
gentlementlegen opened this issue Dec 10, 2024 · 6 comments · Fixed by #115
Closed

Comment fails to be posted on linked pull-request that cannot be started #102

gentlementlegen opened this issue Dec 10, 2024 · 6 comments · Fixed by #115

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Dec 10, 2024

We currently have restrictions on the level of tasks we are able to start (at the moment at least priority 3). However, users can still link a pull-request to that issue if they want to. What happens is that the plugin properly recognizes that the task cannot be started ("⚠ This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)") but fails to post that comment because the starting event comes from the pull-request and not the issue, thus failing with › Cannot post comment because issue is not found in the payload. This comment should be posted otherwise users could think that the plugin is not working properly.

What is to be done

  • properly post the comment that the user cannot start this task
  • add related tests

Example of failed run

ubiquity-os-marketplace/daemon-disqualifier#60 (comment)

Copy link

ubiquity-os-beta bot commented Dec 10, 2024

Copy link

Deadline Sat, Dec 28, 9:55 PM UTC
Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquity-os-beta bot commented Jan 7, 2025

 [ 76.96 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask150
IssueSpecification126.96
ReviewComment10
Conversation Incentives
CommentFormattingRelevancePriorityReward
We currently have restrictions on the level of tasks we are able…
13.48
content:
  content:
    p:
      score: 0
      elementCount: 4
    h2:
      score: 1
      elementCount: 2
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 8
regex:
  wordCount: 111
  wordValue: 0.1
  result: 5.48
1226.96
Resolves #102Depends on https://github.com/ubiquity-os/plugin-…
10
content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 9
  wordValue: 0
  result: 0
0.620

@0x4007
Copy link
Member

0x4007 commented Jan 7, 2025

This was not collaborative so it should have thrown an error, unless you're an admin on this repo.

@gentlementlegen
Copy link
Member Author

@0x4007 Sorry I have full admin rights on this repo / org, what should be the condition for "collaborative"?

@0x4007
Copy link
Member

0x4007 commented Jan 8, 2025

Then it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants