-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self dispatched workflow functions #20
Comments
Note The following contributors may be suitable for this task: Keyrxng
|
This will need a time estimate as well. |
I cant assign labels Probs about a day to rewrite and test everything is working again |
@0x4007 I'm not free today to carry out work but will be over the next day or two as a heads up Thanks for labeling for me. |
A plugin should ideally not dispatch workflows on the behalf of the kernel as that is the job of the kernel. Can't we move everything to the workflow? |
Not as far as I'm aware @whilefoo no. We need to set a delivery url for our BotFather bot updates and so we use our CF worker domain. What would we set it to if using actions? Afaik that's not possible but I'm no expert. I see recent discussion regarding "hybrids" and plugins being able to self-dispatch in another task. I don't feel the kernel needs to gatekeep the ability to dispatch workflows as it has other important jobs too but actually it's an improvement if plugins can self-dispatch for many reasons:
So if the kernel handles handshakes properly and the plugins are reviewed that self-dispatch and/or leverage |
Now that the kernel'
APP_ID
andAPP_PRIVATE_KEY
have been exposed as org secrets I think I should go back to my original implementation where the worker for this plugin controlled the dispatching of it's own workflows for MTProto API (workrooms, etc...) features.The text was updated successfully, but these errors were encountered: