Empty String Check workflow: exclude files
#82
Assignees
Comments
|
The run is failing due to permission reasons @rndquu, this can be closed as not planned probs.
|
There're still empty string warnings so the CI would fail anyway |
|
You are right, my mistake, the original vision for it was that it would only present a diff warning but not crash CI so it would always succeed essentially but the diff would have it's comments |
|
/start |
|
trying to push changes but running into some errors with ESint |
Should be fine when #86 is merged |
+ Evaluating results. Please wait... |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 25 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|
[ 3.24125 WXDAI ]
@Keyrxng
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 2 | 3.24125 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
The run is failing due to permission reasons @rndquu, this can b… | 6.59content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 26
wordValue: 0.1
result: 1.59
| 0.5 | 1 | 1.45125 |
https://github.com/ubiquity/ts-template/blob/7b94011f7e080380dd5… | 7.15content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 37
wordValue: 0.1
result: 2.15
| 1 | 1 | 1.79 |
[ 25 WXDAI ]
@rndquu
⚠️ Your rewards have been limited to the task price of 25 WXDAI.
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 24.83 |
| Issue | Comment | 2 | 5.894 |
| Review | Comment | 8 | 43.141 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Check [this](https://github.com/ubiquity-os/ubiquity-os-plugin-i… | 24.83content:
content:
p:
score: 0
elementCount: 6
ul:
score: 0
elementCount: 2
li:
score: 0.5
elementCount: 4
a:
score: 5
elementCount: 4
result: 22
regex:
wordCount: 51
wordValue: 0.1
result: 2.83
| 1 | 1 | 24.83 |
There're still empty string warnings so the CI would fail anyway | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.8 | 1 | 0.664 |
Should be fine when https://github.com/ubiquity/ts-template/pull… | 5.46content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.5 | 1 | 5.23 |
Check [this](https://github.com/rndquu/ts-template/pull/7) PR wh… | 11.44content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 23
wordValue: 0.1
result: 1.44
| 0.5 | 1 | 10.72 |
Check [this](https://github.com/rndquu/ts-template/pull/7) PR wh… | 17.64content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 3
result: 15
regex:
wordCount: 47
wordValue: 0.1
result: 2.64
| 0.7 | 1 | 16.848 |
Empty string should be removed | 0.39content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 5
wordValue: 0.1
result: 0.39
| 0.9 | 1 | 0.351 |
Default value for `EXCLUDED_FILES` should be removed | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.9 | 1 | 0.414 |
What's the point of keeping this variable empty? Can't we simply… | 1.28content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 20
wordValue: 0.1
result: 1.28
| 0.8 | 1 | 1.024 |
Refactor the code then, so that the `EXCLUDED_FILES` env… | 6.54content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 25
wordValue: 0.1
result: 1.54
| 0.9 | 1 | 6.386 |
YesI don't understand the question. Make sure:1. `EXCL… | 7.11content:
content:
p:
score: 0
elementCount: 5
ol:
score: 0
elementCount: 1
li:
score: 0.5
elementCount: 2
a:
score: 5
elementCount: 1
result: 6
regex:
wordCount: 17
wordValue: 0.1
result: 1.11
| 0.9 | 1 | 6.999 |
You may keep the old regex which only matches double quotes ("")… | 1.33content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 21
wordValue: 0.1
result: 1.33
| 0.3 | 1 | 0.399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check this failing
Empty String Checkworkflow. It fails because there're empty strings in the following places:So there are legit cases when empty strings can be used.
What should be done:
The text was updated successfully, but these errors were encountered: