Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Database: Should Check For Duplicates #623

Closed
0x4007 opened this issue Aug 16, 2023 · 14 comments
Closed

Database: Should Check For Duplicates #623

0x4007 opened this issue Aug 16, 2023 · 14 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Aug 16, 2023

Looks like it is case sensitive. We should be doing this in a more robust way. Lets do by GitHub user ID, but also save their latest username (@ByteBallet changed theirs) for database review convenience.

image
@kamaalsultan
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Aug 16, 2023

Too many assigned issues, you have reached your max of 2

@kamaalsultan
Copy link
Contributor

kamaalsultan commented Aug 16, 2023

Too many assigned issues, you have reached your max of 2
The best I can suggest is that you are allowed to be assigned to two issues at once (more if you have an open pull request review and a 24+ hour delay is caused by our review team.)
#592 (comment)

Is it working?

@kamaalsultan
Copy link
Contributor

kamaalsultan commented Aug 16, 2023

Users can change their user names on github.
#623 (comment)
This happened because I changed my github user name.
It would be good to manage users on database by user id, not user name.

@ubiquibot
Copy link

ubiquibot bot commented Aug 16, 2023

@ByteBallet The time limit for this bounty is on Wed, 16 Aug 2023 19:17:33 UTC

@0x4007
Copy link
Member Author

0x4007 commented Aug 16, 2023

Okay lets do user ID

@kamaalsultan
Copy link
Contributor

I think it should be done after #604 is merged...?

@0x4007
Copy link
Member Author

0x4007 commented Aug 17, 2023

I think it should be done after #604 is merged...?

Don't think its dependent on this.

@kamaalsultan
Copy link
Contributor

I think it should be done after #604 is merged...?

Don't think its dependent on this.

Oh, just confused.

@kamaalsultan
Copy link
Contributor

Isn't it resolved after #618 merged?

@0x4007
Copy link
Member Author

0x4007 commented Aug 17, 2023

Duplicate #618

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
@ubiquibot
Copy link

ubiquibot bot commented Aug 17, 2023

Permit generation skipped because the issue was not closed as completed

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

@0x4007
Copy link
Member Author

0x4007 commented Aug 18, 2023

@ByteBallet looks like the bounty hunter gave up on the original issue as a heads up

@kamaalsultan
Copy link
Contributor

kamaalsultan commented Aug 18, 2023

@ByteBallet looks like the bounty hunter gave up on the original issue as a heads up

Bounty hunter of #618 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants