Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals/Request for Comment View (rfc.ubq.fi) #54

Closed
0x4007 opened this issue Jun 3, 2024 · 30 comments · Fixed by #94
Closed

Proposals/Request for Comment View (rfc.ubq.fi) #54

0x4007 opened this issue Jun 3, 2024 · 30 comments · Fixed by #94

Comments

@0x4007
Copy link
Member

0x4007 commented Jun 3, 2024

I've opened up a couple of proposals, essentially requests for comment. It could be useful to aggregate them onto a single view for ease-of-access to the DAO. Recent examples:

I imagine that we can find issues without pricing and populate them under the "proposals" view.

  1. Fork this repository, make rfc.ubq.fi repository
  2. Fork devpool-directory repository, make devpool-rfc repository
  3. rfc.ubq.fi UI should load from devpool-rfc "backend"

A Note on Forks

It seems that we have use cases for similar UI code but for different purposes. Perhaps it makes sense to fork and create new repos (leaderboard.ubq.fi, rfc.ubq.fi.)

In addition, we already have https://github.com/ubiquity/devpool-directory and https://github.com/ubiquity/devpool-directory-private. Ideally we could consolidate everything into a single aggregator repository, and collect even the github issues without pricing. That way we only need to maintain a single repository (instead of potentially three) for our "backend" of issues.

For now lets just do another fork and then we can worry about consolidating them into a "single backend" in a future project.

@0x4007
Copy link
Member Author

0x4007 commented Jun 3, 2024

@ubiquity/software-development rfc

@0x4007 0x4007 changed the title Proposals View (proposals.ubq.fi?) Proposals/Request for Comment View (rfc.ubq.fi) Jun 3, 2024
@rndquu
Copy link
Member

rndquu commented Jun 4, 2024

Github discussions serve the same purpose.

Regarding a unified UI, we should create a design system first with typography, colors, UI components, etc...(example)

@0x4007
Copy link
Member Author

0x4007 commented Jun 4, 2024

Github discussions serve the same purpose.

We tried using these in the past and it seemed that Issues always were able to handle the business need more effectively than Discussions. In addition, it was an extra step to convert to Issues to start the work. The extra barrier adds friction. That's why we basically no longer use Discussions.

Regarding a unified UI, we should create a design system first with typography, colors, UI components, etc...(example)

The closest thing we've got is dao.ubq.fi/branding can add more detail at some point though.

However I was actually referring to the page layout and everything with the list view etc. It seems like it could be useful for all of the applications.

@0x4007
Copy link
Member Author

0x4007 commented Jun 6, 2024

Alright for now lets just do another fork and then we can worry about consolidating them into a "single backend" in a future project.

@xno-miner
Copy link

/wallet 0x5ea33b5133d418f99C510ae8Bbe83f6040b99338

Copy link

ubiquibot bot commented Jun 11, 2024

+ Successfully registered wallet address

@xno-miner
Copy link

/start

Copy link

ubiquibot bot commented Jun 11, 2024

DeadlineWed, Jun 12, 1:51 PM UTC
Registered Wallet 0x5ea33b5133d418f99C510ae8Bbe83f6040b99338
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@xno-miner
Copy link

Seems to be working with a test issue. Now https://github.com/xno-miner/rfc.ubq.fi/ and https://github.com/xno-miner/devpool-rfc need to be forked to ubiquity.

@0x4007
Copy link
Member Author

0x4007 commented Jun 11, 2024

Please show a test deploy link. It doesn't seem possible if your "backend" has no relevant changes ubiquity/devpool-directory@development...xno-miner:devpool-rfc:development

@xno-miner
Copy link

Oh sorry, I didn't understand the issue fully before, I am currently continuing work.

@xno-miner
Copy link

I have made the changes that should make the backend work, but I am unable to run the bot locally. Please try it out and check if it works.

@0x4007
Copy link
Member Author

0x4007 commented Jun 17, 2024

@rndquu would you mind reviewing the "backend" code? As I recall you are the primary author and would likely be the most effective reviewer.

You can find the "backend" changes here ubiquity/devpool-directory@development...xno-miner:devpool-rfc:development

You can find the proposals directory here https://github.com/xno-miner/devpool-rfc/issues?q=is%3Aissue+


@xno-miner the inverted logic regarding pricing labels:

// if issue HAS the "Price" label then skip it

Seems to make sense to me so I am inclined to believe that the changes are good


Given that the changes are so small, perhaps it makes sense to just handle them in our existing backend? Perhaps you can open a pull to there @xno-miner? I imagine that you can use if else conditionals since the logic seemingly is just the opposite.

@xno-miner
Copy link

xno-miner commented Jun 17, 2024

I have created the pull request, the changes are described in the pull request description.

ubiquity/devpool-directory#1212

@Keyrxng
Copy link
Contributor

Keyrxng commented Aug 10, 2024

I just got pretty confused with these tasks if I'm honest.

The open PR aims to consolidate RFC logic into the current devpool-directory and so does this cover item 1 in Add support for proposals on 'work.ubq.fi': "upgrade backend"?

This spec implies that the work involved with rfc.ubq.fi is a requirement for this task to be completed. Is it expected that this issue won't be complete until the relevant work on the UI is complete too? And if this is true, then is working on work.ubq.fi filtering and an additional view as step 2 required in the larger task?


Seems like 'double dipping' as it's been called before but it leaves only repo-sync-solution as step 3 of the larger task.

Should we point the open PR towards a dedicated task in https://github.com/ubiquity/devpool-directory-bounties/issues and we can allow item 2 of the larger task to be worked on via this task?

Also ubiquity/devpool-directory-tasks#25 is a duplicate of item 3 of the larger task as well. Some consolidating of the issues would make things a lot clearer

@0x4007
Copy link
Member Author

0x4007 commented Aug 11, 2024

I think a separate ui is fine (possible fork of this codebase)

The backend logic must be completed for that new ui to load the right data though.

Please feel free to do as you see fit with the tasks regarding consolidation.

@kingsley-einstein
Copy link

/wallet 0xb69DB7b7B3aD64d53126DCD1f4D5fBDaea4fF578

Copy link
Contributor

ubiquity-os bot commented Sep 25, 2024

+ Successfully registered wallet address

@rndquu
Copy link
Member

rndquu commented Oct 4, 2024

As far as I understand this issue may be closed as "not planned" because https://work.ubq.fi/ now supports displaying both tasks and proposals.

Copy link
Contributor

ubiquity-os bot commented Oct 4, 2024

! You have reached your max task limit. Please close out some tasks before assigning new ones.

@0x4007 0x4007 self-assigned this Oct 4, 2024
Copy link
Contributor

ubiquity-os bot commented Oct 4, 2024

@0x4007 the deadline is at Sat, Oct 5, 2:03 PM UTC

@0x4007 0x4007 closed this as completed Oct 4, 2024
@0x4007
Copy link
Member Author

0x4007 commented Oct 4, 2024

@gentlementlegen third reward that didn't render perhaps it's manifest related

@gentlementlegen
Copy link
Member

@0x4007 Same error as before:

    {
      "message": [
        "Error in event handler",
        "HttpError: This installation has been suspended - https://docs.github.com/rest/reference/apps#create-an-installation-access-token-for-an-app"
      ],
      "level": "error",
      "timestamp": 1728092089294
    }

The app is most likely suspended here or on the target repo.

@0x4007
Copy link
Member Author

0x4007 commented Oct 5, 2024

I'm not sure what to do. We don't want both bots leaving comments

@gentlementlegen
Copy link
Member

@0x4007 I think we should use ubiquibot-os everywhere for now since it is set up.

@0x4007
Copy link
Member Author

0x4007 commented Oct 5, 2024

Please give me actionable steps or you can fix. I don't understand

@gentlementlegen
Copy link
Member

The Beta bot won't be able to run if it is not enabled in the other repo and vice versa it seems. We should only use the production bot everywhere probably.

@0x4007
Copy link
Member Author

0x4007 commented Oct 5, 2024

So we need both bots to have access on marketplace.

We can have a new switch in the config that defines it's only for beta or production bot to read.

If the bot doesn't have a valid config then it shouldn't respond to any user actions, like comments and commands.

@xno-miner
Copy link

Are the payouts fixed yet?

Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024

 [ 691.3435 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueTask1600
IssueSpecification142.45
IssueComment1048.8935
ReviewComment30
Conversation Incentives
CommentFormattingRelevanceReward
I've opened up a couple of proposals, essentially requests for c…
14.15
content:
  content:
    p:
      score: 0
      elementCount: 10
    ul:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    ol:
      score: 1
      elementCount: 1
    h3:
      score: 1
      elementCount: 1
  result: 5.5
regex:
  wordCount: 190
  wordValue: 0.1
  result: 8.65
142.45
@ubiquity/software-development rfc
0.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.2
  result: 0.65
0.70.455
We tried using these in the past and it seemed that Issues alway…
15.02
content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 100
  wordValue: 0.2
  result: 10.02
0.914.018
Alright for now lets just do another fork and then we can worry …
2.98
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 24
  wordValue: 0.2
  result: 2.98
0.82.384
Please show a test deploy link. It doesn't seem possible if your…
3.7
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 31
  wordValue: 0.2
  result: 3.7
0.62.22
@rndquu would you mind reviewing the "backend" code? As I recall…
22.61
content:
  content:
    p:
      score: 0
      elementCount: 6
    hr:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 131
  wordValue: 0.2
  result: 12.61
0.7519.4575
I think a separate ui is fine (possible fork of this codebase) …
4.8
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 42
  wordValue: 0.2
  result: 4.8
0.854.08
@gentlementlegen third reward that didn't render perhaps it's ma…
1.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 12
  wordValue: 0.2
  result: 1.65
0.40.66
I'm not sure what to do. We don't want both bots leaving comments
2
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 15
  wordValue: 0.2
  result: 2
0.51
Please give me actionable steps or you can fix. I don't understa…
1.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 13
  wordValue: 0.2
  result: 1.77
0.30.531
So we need both bots to have access on marketplace. We can have…
5.84
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 53
  wordValue: 0.2
  result: 5.84
0.74.088
Resolves https://github.com/ubiquity/.github/issues/115Resolve…
0
content:
  content:
    p:
      score: 0
      elementCount: 3
  result: 0
regex:
  wordCount: 33
  wordValue: 0
  result: 0
0.80
Cypress is unreliable so I'm ignoring it.
1.17
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.2
  result: 1.17
0.10
It's too bad I can't revert from mobile.
1.42
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0.2
  result: 1.42
0.10

 [ 7.578 UUSD ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueComment27.578
Conversation Incentives
CommentFormattingRelevanceReward
Github discussions serve the same purpose.Regarding a unified …
6.49
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 24
  wordValue: 0.1
  result: 1.49
0.86.192
As far as I understand this issue may be closed as "not planned"…
1.54
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 25
  wordValue: 0.1
  result: 1.54
0.91.386

 [ 1.11975 UUSD ] 

@xno-miner
Contributions Overview
ViewContributionCountReward
IssueComment51.11975
Conversation Incentives
CommentFormattingRelevanceReward
Seems to be working with a test issue. Now https://github.com/xn…
1.85
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 31
  wordValue: 0.1
  result: 1.85
0.80.3675
Oh sorry, I didn't understand the issue fully before, I am curre…
1
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 15
  wordValue: 0.1
  result: 1
0.60.15
I have made the changes that should make the backend work, but I…
1.75
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 29
  wordValue: 0.1
  result: 1.75
0.70.30875
I have created the pull request, the changes are described in th…
1.44
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 23
  wordValue: 0.1
  result: 1.44
0.70.252
Are the payouts fixed yet?
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.40.0415

 [ 7.123 UUSD ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueComment17.123
Conversation Incentives
CommentFormattingRelevanceReward
I just got pretty confused with these tasks if I'm honest.The …
8.38
content:
  content:
    p:
      score: 0
      elementCount: 6
    hr:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 183
  wordValue: 0.1
  result: 8.38
0.857.123

 [ 3.177 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment33.177
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 Same error as before:```json{…
1.11
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
0.90.999
@0x4007 I think we should use `ubiquibot-os` everywhere …
0.94
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 14
  wordValue: 0.1
  result: 0.94
0.70.658
The Beta bot won't be able to run if it is not enabled in the ot…
1.9
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 32
  wordValue: 0.1
  result: 1.9
0.81.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants