Skip to content

Latest commit

 

History

History
207 lines (145 loc) · 9.19 KB

slither-report-checklist.md

File metadata and controls

207 lines (145 loc) · 9.19 KB
Raw

Checklist

This report was generated using:

$ slither src/ --checklist --show-ignored-findings
Compilation warnings/errors on src/GenesisPFP.sol:
Warning: Contract code size is 25496 bytes and exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on Mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
  --> src/GenesisPFP.sol:34:1:
   |
34 | contract GenesisPFP is GenesisBase, IGenesisPFP, ChainlinkVRFMetadata {
   | ^ (Relevant source part starts here and spans across multiple lines).

INFO:Detectors:
ChainlinkVRFMetadata.withdrawRemainingLink(address) (src/abstracts/ChainlinkVRFMetadata.sol#64-68) uses a dangerous strict equality: - balance == 0 (src/abstracts/ChainlinkVRFMetadata.sol#66)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#dangerous-strict-equalities
INFO:Detectors:
ERC721Psi.tokensOfOwner(address).tokenIdsIdx (src/ERC721Psi/ERC721Psi.sol#507) is a local variable never initialized
ERC721Psi.balanceOf(address).count (src/ERC721Psi/ERC721Psi.sol#106) is a local variable never initialized
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#uninitialized-local-variables
INFO:Detectors:
ERC721Psi.\_checkOnERC721Received(address,address,uint256,uint256,bytes) (src/ERC721Psi/ERC721Psi.sol#460-486) ignores return value by IERC721Receiver(to).onERC721Received(\_msgSender(),from,tokenId,\_data) (src/ERC721Psi/ERC721Psi.sol#470-480)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#unused-return
INFO:Detectors:
GenesisPFP.constructor(string,string,string,address,address,address,address).\_name (src/GenesisPFP.sol#72) shadows: - ERC721Psi.\_name (src/ERC721Psi/ERC721Psi.sol#35) (state variable)
GenesisPFP.constructor(string,string,string,address,address,address,address).\_symbol (src/GenesisPFP.sol#73) shadows: - ERC721Psi.\_symbol (src/ERC721Psi/ERC721Psi.sol#36) (state variable)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#local-variable-shadowing
INFO:Detectors:
GenesisPFP.mintWithSignature(MintData,bytes) (src/GenesisPFP.sol#93-124) uses timestamp for comparisons
Dangerous comparisons: - block.timestamp < request.validity_start (src/GenesisPFP.sol#98) - block.timestamp > request.validity_end (src/GenesisPFP.sol#100)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#block-timestamp
INFO:Detectors:
ERC721Psi.\_checkOnERC721Received(address,address,uint256,uint256,bytes) (src/ERC721Psi/ERC721Psi.sol#460-486) uses assembly - INLINE ASM (src/ERC721Psi/ERC721Psi.sol#476-478)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#assembly-usage
INFO:Detectors:
ERC721Psi.\_baseURI() (src/ERC721Psi/ERC721Psi.sol#166-168) is never used and should be removed
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#dead-code
INFO:Detectors:
Pragma version^0.8.0 (src/ERC721Psi/ERC721Psi.sol#15) allows old versions
Pragma version^0.8.0 (src/ERC721Psi/extension/ERC721PsiAddressData.sol#12) allows old versions
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-versions-of-solidity
INFO:Detectors:
Parameter ERC721Psi.safeTransferFrom(address,address,uint256,bytes).\_data (src/ERC721Psi/ERC721Psi.sol#266) is not in mixedCase
Variable ERC721Psi.\_owners (src/ERC721Psi/ERC721Psi.sol#39) is not in mixedCase
Variable ERC721PsiAddressData.\_addressData (src/ERC721Psi/extension/ERC721PsiAddressData.sol#24) is not in mixedCase
Parameter ChainlinkVRFMetadata.requestChainlinkVRF(uint32,uint16).\_callbackGasLimit (src/abstracts/ChainlinkVRFMetadata.sol#50) is not in mixedCase
Parameter ChainlinkVRFMetadata.requestChainlinkVRF(uint32,uint16).\_requestConfirmations (src/abstracts/ChainlinkVRFMetadata.sol#50) is not in mixedCase
Parameter ChainlinkVRFMetadata.fulfillRandomWords(uint256,uint256[]).\_requestId (src/abstracts/ChainlinkVRFMetadata.sol#82) is not in mixedCase
Parameter ChainlinkVRFMetadata.fulfillRandomWords(uint256,uint256[]).\_randomWords (src/abstracts/ChainlinkVRFMetadata.sol#82) is not in mixedCase
Parameter GenesisBase.setBaseURI(string).\_uri (src/abstracts/GenesisBase.sol#46) is not in mixedCase
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#conformance-to-solidity-naming-conventions

Summary

incorrect-equality

Impact: Medium Confidence: High

src/abstracts/ChainlinkVRFMetadata.sol#L64-L68

uninitialized-local

Impact: Medium Confidence: Medium

src/ERC721Psi/ERC721Psi.sol#L507

src/ERC721Psi/ERC721Psi.sol#L106

unused-return

Impact: Medium Confidence: Medium

src/ERC721Psi/ERC721Psi.sol#L460-L486

shadowing-local

Impact: Low Confidence: High

src/GenesisPFP.sol#L72

src/GenesisPFP.sol#L73

timestamp

Impact: Low Confidence: Medium

src/GenesisPFP.sol#L93-L124

assembly

Impact: Informational Confidence: High

src/ERC721Psi/ERC721Psi.sol#L460-L486

dead-code

Impact: Informational Confidence: Medium

src/ERC721Psi/ERC721Psi.sol#L166-L168

solc-version

Impact: Informational Confidence: High

  • ID-9 Pragma version^0.8.0 allows old versions

src/ERC721Psi/extension/ERC721PsiAddressData.sol#L12

  • ID-10 Pragma version^0.8.0 allows old versions

src/ERC721Psi/ERC721Psi.sol#L15

naming-convention

Impact: Informational Confidence: High

src/ERC721Psi/ERC721Psi.sol#L266

src/ERC721Psi/ERC721Psi.sol#L39

src/ERC721Psi/extension/ERC721PsiAddressData.sol#L24

src/abstracts/ChainlinkVRFMetadata.sol#L50

src/abstracts/ChainlinkVRFMetadata.sol#L50

src/abstracts/ChainlinkVRFMetadata.sol#L82

src/abstracts/GenesisBase.sol#L46

src/abstracts/ChainlinkVRFMetadata.sol#L82

INFO:Slither:src/ analyzed (32 contracts with 85 detectors), 19 result(s) found