Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using foreman #12

Open
luckyx1 opened this issue Jun 22, 2014 · 1 comment
Open

using foreman #12

luckyx1 opened this issue Jun 22, 2014 · 1 comment
Assignees
Labels

Comments

@luckyx1
Copy link
Contributor

luckyx1 commented Jun 22, 2014

Is it intended that we install the gem locally, or can we add the gem to the Gemfile?
also in the moocchat / app / middleware /chat_backend.rb there is a lot of put that is being seen in the terminal, can we remove (unless this is intentional) and/or comment them out to follow Armando's email of removing debugger code.

@armandofox
Copy link
Contributor

Is it intended that we install the gem locally, or can we add the gem to the Gemfile?

You always add the gem to the Gemfile. always. then let Bundler install it locally as needed. that way the Gemfile.lock gets the right version.

also in the moocchat / app / middleware /chat_backend.rb there is a lot of put that is being seen in the terminal, can we remove (unless this is intentional) and/or comment them out to follow Armando's email of removing debugger code.

yes please. can whoever owns that code clean it up? two rules we need to follow are:

  • never push code with red (failing) tests to origin/master
  • never push debugging/commented-out code to origin/master


    Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants