Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logout procedure #507

Open
srkirkland opened this issue Sep 7, 2021 · 1 comment
Open

Update Logout procedure #507

srkirkland opened this issue Sep 7, 2021 · 1 comment
Assignees
Labels
Low Priority Fix eventually

Comments

@srkirkland
Copy link
Member

When doing a logout or endEmulate, we want to kill the Harvest auth cookie but not redirect to CAS. Will require making an anonymous page where we can redirect to.

CAS would prefer if you don't do a full SSO logout with your app logout. Plus it'll make emulation 1% faster.

@srkirkland srkirkland added the Low Priority Fix eventually label Sep 7, 2021
@srkirkland srkirkland self-assigned this Sep 7, 2021
@srkirkland
Copy link
Member Author

Details: clicking the logout button fires a POST to the account/logout endpoint, which is in the AccountController.cs. Right now it does a signout and redirects to an external signout page. Here are the steps that it'll take to fix this issue:

  • Put the [HttpPost] attribute on the logout method so it only responds to POST
  • remove the external redirect and instead just return a view return View().
  • Create a new view which has some simple banner text saying "You have successfully been logged out". Look at the current accessDenied.cshtml view from the same controller for an example.

@mxthu313 ☝️

@srkirkland srkirkland assigned mxthu313 and unassigned srkirkland Oct 8, 2021
@srkirkland srkirkland assigned laholstege and unassigned mxthu313 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Fix eventually
Projects
None yet
Development

No branches or pull requests

3 participants