Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSP Report #274

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fix CSP Report #274

merged 2 commits into from
Sep 9, 2020

Conversation

srkirkland
Copy link
Member

CSP Report has always been broken -- the JSON format wasn't handled by the parser but more importantly the content-type for CSP reports isn't application/json so that requires modifying the default input formatter.

@sprucely
Copy link
Contributor

sprucely commented Sep 9, 2020

Not firing on all cylinders today. How does one go about triggering a csp-report? Postman is not cooperating.

@srkirkland
Copy link
Member Author

Not firing on all cylinders today. How does one go about triggering a csp-report? Postman is not cooperating.

I just triggered it by changing the CSP to have a failure, like commenting out the line which allows us to use google-analytics for example. I'm not sure of a good way to do it artificially though I would think postman should work as long as you get the weird content-type correct.

@srkirkland
Copy link
Member Author

closes #273

Copy link
Contributor

@sprucely sprucely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works in Postman.

@srkirkland srkirkland merged commit b1707de into master Sep 9, 2020
@srkirkland srkirkland deleted the srk/csp-report branch September 9, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants