From 8473ca695294203880616b8d2323bed590907bc4 Mon Sep 17 00:00:00 2001 From: Corey Peterson Date: Mon, 8 Jan 2024 13:52:52 -0500 Subject: [PATCH] Hotfix for edge case player question overflow. Fixed bad missingItems reference in player. --- src/src-assets/player-assets/player.coffee | 2 +- src/src-assets/player-assets/player.scss | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/src-assets/player-assets/player.coffee b/src/src-assets/player-assets/player.coffee index 690764eb..6d306bf5 100644 --- a/src/src-assets/player-assets/player.coffee +++ b/src/src-assets/player-assets/player.coffee @@ -405,7 +405,7 @@ angular.module('Adventure', ['ngAria', 'ngSanitize']) $scope.missingRequiredItems = $scope.checkInventory(requiredItems) if $scope.missingRequiredItems[0] - $scope.missingRequiredItemsAltText = missingItems.map((item) -> "#{$scope.itemSelection[$scope.getItemIndex(item.id)].name} (amount: #{requiredItems.find((el) -> el.id is item.id).range});") + $scope.missingRequiredItemsAltText = $scope.missingRequiredItems.map((item) -> "#{$scope.itemSelection[$scope.getItemIndex(item.id)].name} (amount: #{requiredItems.find((el) -> el.id is item.id).range});") $scope.next = null return diff --git a/src/src-assets/player-assets/player.scss b/src/src-assets/player-assets/player.scss index c20096b0..122d2144 100644 --- a/src/src-assets/player-assets/player.scss +++ b/src/src-assets/player-assets/player.scss @@ -64,6 +64,7 @@ body { position: absolute; width: 0; height: 0; + overflow: hidden; } .aria-live-region { @@ -256,6 +257,8 @@ h1 { box-sizing: border-box; margin-bottom: auto; + overflow-y: auto; + background: #fff; @@ -493,7 +496,6 @@ h1 { box-sizing: border-box; max-height: 250px; - overflow-y: auto; font-family: 'Lora', serif;