Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark and possibly change the way fonts are imported #193

Open
advaithg opened this issue Jun 30, 2021 · 0 comments
Open

Benchmark and possibly change the way fonts are imported #193

advaithg opened this issue Jun 30, 2021 · 0 comments
Labels
low-priority not a huge deal if we don't get done, but great extra work to pick up

Comments

@advaithg
Copy link
Contributor

  • first, benchmark the font load time with our current setup
  • then, try the swap that Bryan suggests here
  • then, benchmark the font load time with the new system

If the font load time has no impact, switch to the suggested swap.

While the current fonts have no issues, we're loading it inside <Head>, which feels kinda gnarly

Probably could wait to do this until Issue #191 is resolved.
@mattxwang mattxwang added the low-priority not a huge deal if we don't get done, but great extra work to pick up label Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-priority not a huge deal if we don't get done, but great extra work to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattxwang @advaithg