CSS Cleanup and .module SCSS
#200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. had some classes that didn't exist (half-size) 2. converted classnames to camel case 3. imported variables into module file 4. imported module file in about page
1. Currently breaks mobile navbar - should be fixed when converting navbar 2. Removed empty classes (banner-main-content)
also changed calendar classnames and added a CSS comment for when we remove pause state
TODO: change import when button component is converted
additionally also changed techgala banner on index page to use modular scss
midway through converting footer as of now
globals should be unnecessary at this point of time gm page needs to be checked when routing is fixed
|
Closing this post conversation with @mattxwang and deciding in favor of an incremental approach to slowly bleed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #191
Currently in progress
convert pages and components to modules
remove repeated CSS and make it global
Renames most SCSS files to
.module.scssConverts SCSS to camel case when using modules, and imports styles into js files
Removes unnecessary CSS classes