Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts about page to .module scss #204

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

advaithg
Copy link
Contributor

@advaithg advaithg commented Jul 8, 2021

First PR for issue #191 .
Only converts the about page to .module scss.

dependabot bot and others added 5 commits July 6, 2021 13:13
Bumps [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) from 11.0.0 to 11.0.1.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](https://github.com/vercel/next.js/commits/v11.0.1/packages/eslint-config-next)

---
updated-dependencies:
- dependency-name: eslint-config-next
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [next](https://github.com/vercel/next.js) from 11.0.0 to 11.0.1.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v11.0.0...v11.0.1)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 7.29.0 to 7.30.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.29.0...v7.30.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
While working on #187, I noticed that we "waste" a bit of Actions time rebuilding, linting, and running CodeQL against PRs that only introduce changes to `README.md`. Since we aren't using a markdown linter like `remark`, these Actions are all going to be a no-op.

So, this PR disables these actions on commits that only change `README.md`. If this is useful, we may want to:

* expand the set of files that we don't run changes against
* push this change upstream to other react projects we use, particularly the react starters that Teach LA uses
@advaithg advaithg requested a review from mattxwang July 8, 2021 05:23
@advaithg advaithg changed the base branch from main to update-stylelint-modules July 8, 2021 08:45
@advaithg advaithg merged commit f1d9845 into update-stylelint-modules Jul 8, 2021
@advaithg advaithg deleted the about-page-module-scss branch July 8, 2021 08:46
advaithg added a commit that referenced this pull request Jul 9, 2021
…#201)

* updated stylelint for modules

* multiline extends

* Converts about page to `.module` scss (#204)

* converted back to hyphenated styles

* changes to dot notation for eslint, changes partial extension import rule for eslint as stopgap

* gets rid of stylelint-config-css-modules, since no longer necessary

* removed commented import on app.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants