Add GRIDSS somatic filter #187
Conversation
| @@ -37,6 +37,17 @@ process { | |||
| } | |||
| } | |||
|
|
|||
| withName: filter_sSV_GRIDSS { | |||
| cpus = 1 | |||
| memory = 20.GB | |||
There was a problem hiding this comment.
Have you tested to see how much memory this step uses with a variety of samples. Could there be an upper bound?
Also, did you consider this:
The Hartwig Medical Foundation has reimplemented gridss_somatic_filter in Java as [GRIPSS](https://github.com/hartwigmedical/hmftools/tree/master/gripss). GRIPSS is much faster, has additional features, and is the recommended tool for somatic filtering of GRIDSS output.
|
Bleep bloop, I am a robot. This is embarrassing... the cd /path/to/your/repository/
git checkout mmootor-filter-gridss
git fetch origin
git merge origin/main
git push origin |
|
I specifically merged |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Description
Add GRIDSS somatic variant filter.
Closes #186
Testing Results
Checklist
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have reviewed the Nextflow pipeline standards.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
I have added my name to the contributors listings in the
manifestblock in thenextflow.configas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.I have updated the version number in the
metadata.yamlandmanifestblock of thenextflow.configfile following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)I have tested the pipeline on at least one A-mini sample with
algorithm = ['delly', 'manta']. The paths to the test config files and output directories are attached above.