Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in R_LIBS_SITE env variable? #4

Open
aryarm opened this issue Jan 10, 2022 · 0 comments
Open

typo in R_LIBS_SITE env variable? #4

aryarm opened this issue Jan 10, 2022 · 0 comments

Comments

@aryarm
Copy link
Collaborator

aryarm commented Jan 10, 2022 •
edited
Loading

While reading through the Dockerfile, I noticed that one of the environment variables might be misspelled?

cmm262-notebook/Dockerfile

Line 35 in 843e669

ENV R_LIB_SITE=/opt/conda/envs/r-bio/lib/R/library

Shouldn't this be R_LIBS_SITE (with an S after the LIB), instead?

As far as I can tell, the setup on Datahub has been working so far, so I'm not sure it's a major concern to address this. But I thought I would mention it just in case. Feel free to close this issue if it isn't something to worry about.
aryarm added a commit that referenced this issue Dec 16, 2022
@aryarm
Merge pull request #4 from biom262/docker-caching
ec75d63 
enable docker layer caching to speed up builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aryarm