Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage DraggableScrollabeController Once It's Available #150

Closed
caseycrogers opened this issue Dec 29, 2021 · 7 comments
Closed

Leverage DraggableScrollabeController Once It's Available #150

caseycrogers opened this issue Dec 29, 2021 · 7 comments

Comments

@caseycrogers
Copy link
Contributor

caseycrogers commented Dec 29, 2021

When #149 goes in, developers using the expandable bottom sheet feature will have to use FeedbackSheetDragHandle in the feedback sheet builder to provide a visual drag handle for users.

This is pretty clunky, but the only way to do it because the drag handle needs to be placed as a fixed header on top of their scrollable widget in order for users to be able to click and drag on it to drag the sheet. Once DraggableScrollableSheet supports programmatic control in production (see: flutter/flutter#92440) we can pull the drag handle out of the builder so that developers don't have to provide it.

Additionally, the feedback_widget uses a value notifier internally to manage sheet related animations. This can also be replaced by referencing the controller directly assuming the controller is made a ChangeNotifier.

@caseycrogers caseycrogers changed the title Pull Drag Handle Out of Feedback Builder Leverage DraggableScrollabeController One It's Available Dec 29, 2021
@ueman ueman changed the title Leverage DraggableScrollabeController One It's Available Leverage DraggableScrollabeController Once It's Available Jan 8, 2022
@kamami
Copy link

kamami commented Jan 25, 2022

Any updates to this?

@ueman
Copy link
Owner

ueman commented Jan 25, 2022

DraggableScrollabeController will probably be included in the next Flutter version. There's no date for that yet, but I expect it to be around February or March.

@kamami
Copy link

kamami commented Jan 25, 2022

Is already on master and fully functional?

@ueman
Copy link
Owner

ueman commented Jan 25, 2022

I'm not sure what you're referring to. flutter/flutter#92440 is already on master and fully functional. This library however doesn't yet support it.

@kamami
Copy link

kamami commented Jan 25, 2022

Thanks for your response! I missed that this is a separate package...

@quoc-huynh-cosee
Copy link
Contributor

quoc-huynh-cosee commented Jul 13, 2023

Any updates on this? I need to expand the sheet programatically.

@ueman
Copy link
Owner

ueman commented Sep 24, 2023

Closed via #239

@ueman ueman closed this as completed Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants