Fix/bugs in apple passkit getPasses #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
reviewed
Nov 28, 2024
| return type; | ||
| } | ||
| } | ||
| throw ArgumentError('Invalid PKPassType value: $jsonValue'); |
There was a problem hiding this comment.
What do you think of falling back to any instead of throwing?
There was a problem hiding this comment.
I think it is a good solution, it removes the necessity for exception handling.
ueman
reviewed
Nov 29, 2024
| @@ -61,13 +61,42 @@ class ApplePkPass { | |||
| } | |||
|
|
|||
| /// Status after trying to add multiple passes. | |||
| enum PkPassType { | |||
| enum PKPassType { | |||
There was a problem hiding this comment.
Even though the name more closely resembles the iOS name, this is a breaking change. I don't think we should do a bump of the major version for this fix
There was a problem hiding this comment.
If you agree I will revert the name change, I think it is ok how it was before
ueman
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.