Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure functions inside AuthenticationResponse.tsx are in the correct format #190

Closed
AlexanderWangY opened this issue Feb 28, 2024 · 2 comments
Closed

Ensure functions inside AuthenticationResponse.tsx are in the correct format #190

AlexanderWangY opened this issue Feb 28, 2024 · 2 comments
Labels
Easy A simple problem or change that needs to be fixed or made. Good first issue Good for newcomers Refactor Rewriting functions, changing names, improving code readability, reducing complexity

Comments

@AlexanderWangY
Copy link
Collaborator

Currently, there are some functions in the AuthenticationResponse.tsx that are function xxx() but due to the coding style guide we need to change it to an arrow function.

Bonus points if you figure out a good a clean method to store the Error class as well. Possibly in a new folder/file called classes.ts or something?
@AlexanderWangY AlexanderWangY added Good first issue Good for newcomers Easy A simple problem or change that needs to be fixed or made. Refactor Rewriting functions, changing names, improving code readability, reducing complexity labels Feb 28, 2024
@Phantom0110
Copy link
Contributor

I got this.

@AlexanderWangY
Copy link
Collaborator Author

Closed by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy A simple problem or change that needs to be fixed or made. Good first issue Good for newcomers Refactor Rewriting functions, changing names, improving code readability, reducing complexity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexanderWangY @Phantom0110