Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer one public class per file over monolithic files #5

Open
Nikhil-42 opened this issue Mar 3, 2023 · 1 comment
Open

Prefer one public class per file over monolithic files #5

Nikhil-42 opened this issue Mar 3, 2023 · 1 comment
Assignees
@Nikhil-42 @levyjonathan31
Labels
enhancement New feature or request

Comments

@Nikhil-42
Copy link
Collaborator

Description

The m_array.py module contains definitions and implementations for several related but public classes. This drastically reduces the readability of the file. There is general refactoring required here such as making MArrayElement an internal class, and splitting MArraySlidingWindow to a different file.
@Nikhil-42 Nikhil-42 added the enhancement New feature or request label Mar 3, 2023
@Nikhil-42
Copy link
Collaborator Author

Also, the file name should match the main class defined in that file. Ie "m_array.py" -> "marray.py" and "marrayslidingwindow.py"

@Nikhil-42 Nikhil-42 self-assigned this Mar 4, 2023
@levyjonathan31 levyjonathan31 self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-42 Nikhil-42

@levyjonathan31 levyjonathan31

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nikhil-42 @levyjonathan31