Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule for Thompson cloud microphysics (and maybe others) #151

Open
dustinswales opened this issue Jan 3, 2024 · 3 comments
Open

Submodule for Thompson cloud microphysics (and maybe others) #151

dustinswales opened this issue Jan 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dustinswales
Copy link
Collaborator

Description

Move the core of the Thompson cloud microphysics from ccpp-physics into a submodule that could be referenced by ccpp-physics within the UFS, and by other hosts. With this reorganization, a testing framework will be added for hierarchical offline testing (e.g. unit-tests of scheme components-> idealized cases). The hope is to provide relief for developers that have to maintain schemes shared across hosts, or host applications, while also hardening up the testing.

Questions

Where should this submodule reside? It's history weaves through many NOAA and non-NOAA labs and centers, so it's complicated. (Currently here for testing)
What should it be called? thompson_cloud_physics?

@yangfanglin @lisa-bengtsson @ligiabernardet @gthompsnWRF @AndersJensen-NOAA

@yangfanglin
Copy link
Collaborator

@RuiyuSun adding Ruiyu to the discussion.

My preference is to keep this scheme/submodule under the CCPP repo, if it is feasible. I understand rrtmgp is an exception but we should prevent the physics package from being further scattered in different individual and/or institutional repos.

"thompson_cloud_physics" looks to be a good choice.

@dustinswales is there an intention to change most if not all parameterizations to submodules ? Sorry for asking if this has been discussed before. What are the pros and cons ?

@dustinswales
Copy link
Collaborator Author

@yangfanglin There is some interest by scheme developers to do this, but it's small fraction, isolated to schemes that are currently being developed in parallel across multiple hosts (Thompson MP and C3).

We've touched on using submodules here and there in the ccpp physics management meetings, along with at the CCPP Visioning workshop, but this is the first time that code is being moved from ccpp-physics into a submodule. The idea of isolating the model-agnostic part of the scheme and placing it in it's own repository is to centralize the development and reduce the code management burden for the developers.

@lisa-bengtsson
Copy link
Collaborator

@dustinswales @yangfanglin for C3, we have a meeting scheduled on January 9th to discuss pros and cons with this approach, I believe it is not yet decided that this will be the way to go. @yangfanglin I can add you to that meeting if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants