Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: shortenTextAfterLength isn't adhering to provided prop #15

Open
CamdenFoucht opened this issue Sep 20, 2023 · 3 comments
Open

Bug: shortenTextAfterLength isn't adhering to provided prop #15

CamdenFoucht opened this issue Sep 20, 2023 · 3 comments

Comments

@CamdenFoucht
Copy link

CamdenFoucht commented Sep 20, 2023 •
edited
Loading

Hello,

I was testing the new shortenTextAfterLength prop and it seems to always use 20 even when a custom length such as 200 is being provided.

I also tried using 0 to disable the feature, and seems it was still shortening text to the default of 20

Also could the default be made higher? I think 20 is slightly too short, I think 80 or 100 would be a better default value for this property 🙂
jaywcjlove added a commit that referenced this issue Sep 21, 2023
@jaywcjlove
fix: fix shortenTextAfterLength props. #15
e9f5b24
@jaywcjlove
Copy link
Member

@CamdenFoucht Upgrade v2.0.0-alpha.6

github-actions bot pushed a commit that referenced this issue Sep 21, 2023
@jaywcjlove
fix: fix shortenTextAfterLength props. #15 e9f5b24
1fee675
jaywcjlove added a commit that referenced this issue Sep 21, 2023
@jaywcjlove
fix: fix shortenTextAfterLength props. #15
e8ad00e
jaywcjlove added a commit that referenced this issue Sep 21, 2023
@jaywcjlove
released v1.12.1 #15
f0f8799
github-actions bot pushed a commit that referenced this issue Sep 21, 2023
@jaywcjlove
fix: fix shortenTextAfterLength props. #15 e8ad00e
456032d
github-actions bot pushed a commit that referenced this issue Sep 21, 2023
@jaywcjlove
released v1.12.1 #15 f0f8799
29d2033
@jaywcjlove
Copy link
Member

If it is v1 version, you can upgrade to v1.12.1 @CamdenFoucht

@jaywcjlove
Copy link
Member

https://codesandbox.io/embed/romantic-leftpad-jtqx56?fontsize=14&hidenavigation=1&theme=dark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaywcjlove @CamdenFoucht