Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ww3_ounf] PHIOC referenced instead of PHICE #45

Closed
ukmo-ccbunney opened this issue Sep 15, 2023 · 3 comments
Closed

[ww3_ounf] PHIOC referenced instead of PHICE #45

ukmo-ccbunney opened this issue Sep 15, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ukmo-ccbunney
Copy link
Member

In the large IF block for selecting the output fields in ww3_ounf, the output for PHICE contains a reference to PHIOC which I am pretty sure is an error:

WW3/model/src/ww3_ounf.F90

Lines 1815 to 1820 in 991daf8

ELSE IF ( IFI .EQ. 6 .AND. IFJ .EQ. 11 ) THEN
IF (NCVARTYPEI.EQ.3) NCVARTYPE=4
DO ISEA=1, NSEA
PHIOC(ISEA)=MIN(3000.,PHIOC(ISEA))
END DO
CALL S2GRID(PHICE(1:NSEA), X1)

PHICE is still output using the correct field, but the MIN calculation is performed on the PHIOC variable (line 1818 in the excerpt above).

@ukmo-ccbunney ukmo-ccbunney added the bug Something isn't working label Sep 15, 2023
@ukmo-ccbunney ukmo-ccbunney self-assigned this Sep 15, 2023
@ukmo-ccbunney
Copy link
Member Author

ukmo-ccbunney commented Oct 5, 2023

Looking a bit closer, I think that lines 1817-1819 simply need to be removed (no MIN needs to be applied to PHICE).
Can someone confirm this is sensible (@mickaelaccensi ?)

@mickaelaccensi
Copy link
Collaborator

yes I confirm, it seems to be a bad copy/paste from PHIOC section

@ukmo-ccbunney
Copy link
Member Author

Replaced by issue tracked on NOAA-EMC/issues/1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants