Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions need updating as it may fail using setup.py #107

Open
ldbiz opened this issue Jul 10, 2023 · 2 comments
Open

Build instructions need updating as it may fail using setup.py #107

ldbiz opened this issue Jul 10, 2023 · 2 comments
Assignees

Comments

@ldbiz
Copy link
Contributor

ldbiz commented Jul 10, 2023

Invoking setup.py directly is deprecated see also this pywb issue

Documentation should be updated to reflect as there may be build issues otherwise.

eg. https://github.com/ukwa/ukwa-pywb/blob/master/README.md?plain=1#L44

should be ok with "pip install ." as a replacement.

Setup.py itself is still used by the commands replacing the direct invocation.

@anjackson
Copy link
Contributor

I noticed the same on the parent project: https://github.com/search?q=repo%3Awebrecorder%2Fpywb+%22setup.py+install%22+language%3AreStructuredText&type=code

Perhaps a good idea to make PRs to update both?

@ldbiz ldbiz self-assigned this Sep 1, 2023
@ldbiz
Copy link
Contributor Author

ldbiz commented Sep 26, 2023

I've spent some time looking into this to see what is involved in also changing the existing setup.py invocations as well as the docs, as that would in theory fix the related install issues.

There are however a number of custom commands in both repos setups - they should still run ok (eg. here) if the scope is limited to bare install replacement (changing "python setup.py install" to "pip install .") but even with that the testing might be significant and its not clear it is a priority at the moment, so I will stick to the original scope here and just amend documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants