Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crawl-time screenshots etc. to be accessed #62

Open
anjackson opened this issue Dec 29, 2020 · 2 comments
Open

Allow crawl-time screenshots etc. to be accessed #62

anjackson opened this issue Dec 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@anjackson
Copy link
Contributor

Ideally, we would access screenshots etc, directly via Wayback. This means using the current screenshot:http://example.org/ URL format. PyWB can be monkeypatched to allow these extended URI schemes, but they the access system doesn't allow the call through (and it's not 100% clear what the ACL systems does with these compound schemes).

But, if that can be worked out, then we can make crawl-time screenshots and related material available from PyWB.

Alternatively, we could do this via ukwa-access-api, but as that refers to PyWB to determine the access rights, it hits the same problem.

@anjackson
Copy link
Contributor Author

anjackson commented Oct 25, 2023

Gah, this is also affecting the video work, as urn:embeds prefixed URLs like urn:embeds:http://www.snp.org/blog/post/2012/feb/scottish-independence-good-england are not allowed through.

@anjackson anjackson added the bug Something isn't working label Oct 25, 2023
@anjackson
Copy link
Contributor Author

Note that the location for modifications is...

https://github.com/webrecorder/pywb/blob/83b2113be2c2574ec120ba292006d706e3cc3d53/pywb/manager/aclmanager.py#L132-L148

Where we need to strip off prefix schemes prior to canonicalization, but I'll need to get Ilya's sign off on whether I've missed something and it's not such a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant