-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022-Q2 Work Package: UKWA PyWB Support for Document Access #74
Comments
It might be good to clarify what part of this should happen here in pywb and what is only in the electron NPLD Viewer. Assume that this will only be accessed via the electron app (outside testing), some things might make sense to do there.
The live proxying will be in pywb.
pywb can just display a frame with no banner for this. Should the NPLD viewer have UKWA branding at all, as part of the nav location bar, but no access to calendar?
This would be in the NPLD Viewer
This will also be part of the NPLD viewer and not in pywb. |
Unfortunately, I think everything on this ticket needs to be part of PyWB (or the NGINX it's deployed with). The terms of use may need to be displayed by PyWB in some contexts, so it's probably better to add it to PyWB/NGINX. The same applies to blocking Accessibility does cover the NPLD Player UI, but also covers the PyWB navigation, calendar pages, and PDF/ePub viewers. Or course, if we find problems with pdf.js/ePub.js all we can do is raise them upstream, but both projects take accessibility seriously and so this should work out over time. I believe the PyWB templates/pages are already okay in terms of accessibility. BTW, I've been working on integrating basic accessibility testing into our routine tests. See ukwa/docker-robot-framework#5 |
As discussed in Slack, the download block should probably done in the browser. If this causes problems, we'll revisit the issue. |
This is looking pretty good now, although printing is not quite right. |
So, apparently, the British Library fork of Universal Viewer (https://github.com/britishlibrary/universalviewer) supports PDF and ePub, but also has enhanced features like print layouts, citation support, etc. This was developed during an earlier iteration of this project, but I'm struggling to find documentation on how it should be used. As I understand it, we could bundle this as the viewer, but it would mean setting up support for IIIF manifests, and it's not clear if ePub streaming would work. |
Noting that the appearance of any collection can be modified by adding alternative template files according the standard directory structure. |
Implemented branding changes over in https://github.com/ukwa/npld-access-stack/tree/main/pywb which is part of the repository that controls how PyWB is deployed for the NPLD service. |
I've moved some follow-on support issues to #100 |
Thanks for all that. |
The design re-uses the existing PyWB system to provide single-concurrent-use locks on ‘live’ content drawn from a downstream HTTP document delivery server. https://github.com/ukwa/ukwa-pywb/milestone/2
This is under development on the custom-viewers branch. Deployment configuration is in ukwa-services/access/rrwb.
To complete the design, we require the ukwa-pywb service to be modified to:
The text was updated successfully, but these errors were encountered: