Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible image drawing issues #13426

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Conversation

zhixuwei
Copy link
Contributor

@zhixuwei zhixuwei commented Nov 21, 2024

I have read the CLA Document and I sign the CLA

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improves image annotation logic in the plotting utility of YOLOv5.

πŸ“Š Key Changes

  • Adjusted the loop in the plot_images function to iterate consistently over the entire batch size (bs).

🎯 Purpose & Impact

  • Consistency in Annotations: Ensures that all images in the batch are consistently annotated, potentially increasing the reliability of visual output. πŸ“·
  • Improved Visualization: Enhances the clarity and accuracy of annotations in image mosaics, which is beneficial for users evaluating model predictions. πŸ“ˆ

zhixuwei and others added 4 commits November 21, 2024 15:30
Fixed non-meaningful labels in the top right (row 1, column 4) plots when batch size is larger than max_subplots.

Signed-off-by: zzzer <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Simple loop conditions

Signed-off-by: zzzer <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added the enhancement New feature or request label Nov 21, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @zhixuwei, thank you for submitting an ultralytics/yolov5 πŸš€ PR! This is an automated response, and an Ultralytics engineer will assist you soon. In the meantime, to ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Make sure your commit messages are clear and concise.
  • βœ… Synchronize with Source: Verify your PR is synchronized with the ultralytics/yolov5 main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Ensure all Ultralytics Continuous Integration (CI) checks pass. If any checks fail, please address them.
  • βœ… Update Documentation: Update the relevant documentation for any new features or modifications.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, ensuring all tests pass successfully.
  • βœ… Sign the CLA: Ensure you've signed our Contributor License Agreement by stating, "I have read the CLA Document and I sign the CLA" in the PR comments.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary. As Bruce Lee wisely said, "It is not daily increase but daily decrease, hack away the unessential."

For more guidance, please refer to our Contributing Guide. If your PR is related to a bug, please provide a minimum reproducible example (MRE) to aid the review process. If you have any questions, feel free to leave a comment. Thank you for contributing to Ultralytics! πŸš€βœ¨

@zhixuwei
Copy link
Contributor Author

zhixuwei commented Nov 21, 2024

@glenn-jocher Simplify the loop conditions for this PR

@glenn-jocher glenn-jocher merged commit 4c904ac into ultralytics:master Nov 23, 2024
4 checks passed
@glenn-jocher
Copy link
Member

@zhixuwei thank you, PR merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants