-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pre-commit with Ultralytics Actions #12572
Conversation
This pull request adds an improved Ultralytics Actions workflow to automatically format code and documentation to the new Ultralytics official standards maintained at https://github.com/ultralytics/actions. Four individual actions are run by default. To disable actions, set them to false, i.e. 'python: false'. To customize an action use a `pyproject.toml` file in this repo, and see the individual action repo for details. ```yaml name: Ultralytics Actions on: push: branches: [main] pull_request: branches: [main] jobs: format: runs-on: ubuntu-latest steps: - name: Run Ultralytics Formatting uses: ultralytics/actions@main with: python: true docstrings: true markdown: true spelling: true ``` Signed-off-by: Glenn Jocher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be good to check the codespell
suggestions by hand instead of lumping them in an auto-format commit. I found at least one auto-corrected crate
-> create
, which is plainly incorrect (since it's hard to detect a create
from an image, but crate
s are more readily there).
This PR also fails to delete the conflicting flake8 + isort + yapf + pre-commit configuration.
" crate 50 0.52 0.82\n", | ||
" create 50 0.52 0.82\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not a correct typo fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these exclude words are in the pyproject.toml settings that are missing from this PR, I need to add it!
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
Signed-off-by: Glenn Jocher <[email protected]>
This pull request adds an improved Ultralytics Actions workflow to automatically format code and documentation to the new Ultralytics official standards maintained at https://github.com/ultralytics/actions.
Four individual actions are run by default. To disable actions, set them to false, i.e. 'python: false'.
To customize an action use a
pyproject.toml
file in this repo, and see the individual action repo for details.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
WARNING⚠️ this PR is very large, summary may not cover all changes.
🌟 Summary
Implemented automatic code formatting and standards enforcement for Ultralytics PRs.
📊 Key Changes
🎯 Purpose & Impact