Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Leaderboard wrong data #321

Open
cryptoekof opened this issue Mar 5, 2024 · 1 comment
Open

NFT Leaderboard wrong data #321

cryptoekof opened this issue Mar 5, 2024 · 1 comment

Comments

@cryptoekof
Copy link

Seems like the NFT leaderboard is not accurate (the marketcap is not correct currently) and we could think on adding a little more information even.

I would like to propose some changes using nftpricefloor.com API (https://api.nftpricefloor.com/)

  • Fetch collections by Marketcap in USD
  • At 'Total Value Secured' > NFTs (no idea where that come from tho), nftpricefloor gives a Total Market Cap of the NFT market and '% daily change'.

Extra:

  • Adding Brands or Artists Marketcap?
@alextes
Copy link
Member

alextes commented Mar 5, 2024

Love it. It comes from the older typescript repo that still does a bunch of the analysis for the site. Never completed the migration to Rust. I can give you access so you can see if a PR feels good.

Side note: it's written in a bit of a functional programming style, but I'm happy to explain anything that appears confusing if that forms an obstacle. You should feel free to ignore all that an write whatever typescript you're comfortable with. You only really need to call the API and put the data in the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants