Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update target from 2019 to 2022 #12018

Closed
wants to merge 1 commit into from

Conversation

li-jia-nan
Copy link
Contributor

@li-jia-nan li-jia-nan commented Dec 30, 2023

想用一下顶层 await:

image

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2023 7:48pm

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7385a87) 28.77% compared to head (14a23a7) 28.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12018   +/-   ##
=======================================
  Coverage   28.77%   28.77%           
=======================================
  Files         489      489           
  Lines       14962    14962           
  Branches     3554     3554           
=======================================
  Hits         4305     4305           
  Misses       9891     9891           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fz6m
Copy link
Contributor

fz6m commented Dec 31, 2023

改这个没用,这个 tsconfig.base.json 是用来构建 umi 的产物的 target ,和你在 dumi 里使用啥没关系,主要是取决于你用 top level await 的那个地方的运行时必须支持。

要看 theme/plugin.ts 是怎么加载的,如果是 cjs ,那就没法使用 top level await 。

@li-jia-nan
Copy link
Contributor Author

改这个没用,这个 tsconfig.base.json 是用来构建 umi 的产物的 target ,和你在 dumi 里使用啥没关系,主要是取决于你用 top level await 的那个地方的运行时必须支持。

要看 theme/plugin.ts 是怎么加载的,如果是 cjs ,那就没法使用 top level await 。

先close了,好像不太好升,先用v4吧

@li-jia-nan li-jia-nan closed this Dec 31, 2023
@li-jia-nan li-jia-nan deleted the target-b branch December 31, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants