comment adds new comment with every commit #145

maxkarkowski · 2023-11-27T14:02:05Z

since we updated changesets-gitlab we have now the issue that with every commit the changesets-gitlab comment command creates a new comment in our merge request. before the update it only created one comment for a merge request.

JounQin · 2023-11-27T14:15:02Z

Any screenshot?

Should be related to #138 or #143(most likely)

cc @alan910127

alan910127 · 2023-11-27T17:29:11Z

Hello @maxkarkowski, are you upgraded from v0.11.0 or v0.10.x?
This information can help me locate the issue faster 😄

maxkarkowski · 2023-11-28T07:27:45Z

hey @alan910127 sorry of course i can. we are currently on version 0.10.3

Update:
update to latest version and the problem is still there

maxkarkowski · 2023-11-28T07:37:19Z

Any screenshot?

Should be related to #138 or #143(most likely)

cc @alan910127

here is a screenshot

maxkarkowski · 2023-11-28T07:45:07Z

but even if there is a changeset found, new comment will appear with everey command run

alan910127 · 2023-11-29T07:17:13Z

Hey @maxkarkowski, I couldn't reproduce the error on a project created on gitlab.com. Could you provide some information that might be related to this issue?

Here's something I think might be relevant:

CI_MERGE_REQUEST_IID predefined variable
Discussions API

idumancic · 2023-11-29T09:16:45Z

@alan910127 I have the same problem, we are using a self-hosted instance of GitLab if that helps, but when I tested on gitlab.com I also did not get any error.

maxkarkowski · 2023-11-29T09:20:03Z

@alan910127 I have the same problem, we are using a self-hosted instance of GitLab if that helps, but when I tested on gitlab.com I also did not get any error.

we are also using a self hosted gitlab

maxkarkowski · 2023-11-29T09:22:52Z

Hey @maxkarkowski, I couldn't reproduce the error on a project created on gitlab.com. Could you provide some information that might be related to this issue?

Here's something I think might be relevant:

CI_MERGE_REQUEST_IID predefined variable

Discussions API

this is the comment job we have . it runs on every merge request

comment:
  rules:
    - if: '$CI_MERGE_REQUEST_IID && $CI_COMMIT_BRANCH != "changeset-release/main"'
  extends:
    - .init-pnpm
  script:
    - pnpm changesets-gitlab comment # comment automatically like https://github.com/changesets/bot
    
.init-pnpm:
  before_script:
    - corepack enable
    - corepack prepare [email protected] --activate
    - node --max-old-space-size=8192
    - pnpm config set store-dir .pnpm-store
    - pnpm install # install dependencies
  cache:
    key:
      files:
        - pnpm-lock.yaml
    paths:
      - .pnpm-store

alan910127 · 2023-11-30T07:44:37Z

Got it. I will try to spin up a self-hosted GitLab instance and test the issue inside that.
What's your GitLab version in case it helps?

maxkarkowski · 2023-11-30T15:11:30Z

Got it. I will try to spin up a self-hosted GitLab instance and test the issue inside that. What's your GitLab version in case it helps?

ist GitLab Community Edition v16.6.0

JounQin · 2023-12-04T09:42:02Z

I may have opportunity to test and debug this issue on our internal GitLab service today, I'll try to give a fix soon.

I'm meeting bigger issues...:

alan910127 · 2023-12-04T15:35:20Z

@JounQin I have found that the /projects/:id/merge_requests/:merge_request_iid/diffs is only available on GitLab 15.7 or above.
However, it's not documented very well though 😕, there is only a mention at the docs for changes API.

Reverting #143 could solve the 404 issue and potentially this issue as well.

Update:

Using [email protected] in a GitLab 13 instance does not have the issue of commenting repeatedly.
So, reverting #143 should also solve this one, but there will always be a deprecation warning in the pipeline though 😅.

close #145 --------- Co-authored-by: JounQin <[email protected]>

alan910127 · 2023-12-04T18:19:28Z

@maxkarkowski @idumancic It should be fixed in version 0.11.4, you can try it out!

maxkarkowski · 2023-12-05T10:10:40Z

@maxkarkowski @idumancic It should be fixed in version 0.11.4, you can try it out!

didnt fix it for me :/

JounQin · 2023-12-05T10:43:53Z

@maxkarkowski Please provide more details, such as GitLab instance version?

maxkarkowski · 2023-12-05T12:23:49Z

@maxkarkowski Please provide more details, such as GitLab instance version?

it is still GitLab Community Edition v16.6.0. ;) i just updated to the newest version of changesets-gitlab. the pipeline then executes pnpm changesets-gitlab comment .
i first commited without a changeset. then i added a changeset and commit this as well. and now i have still 2 comments in my merge request

alan910127 · 2023-12-06T11:20:13Z

I'm a bit hesitant to admit this, but I'm having difficulty configuring a GitLab CE instance in a newer version with runners correctly. Would anyone be willing to grant me access to their GitLab instance so that I can test for the issue?

maxkarkowski · 2023-12-06T12:22:13Z

I'm a bit hesitant to admit this, but I'm having difficulty configuring a GitLab CE instance in a newer version with runners correctly. Would anyone be willing to grant me access to their GitLab instance so that I can test for the issue?

sorry for the inconvenience but i cannot share my gitlab instance because it is owned by customer with very sensitive data

idumancic · 2023-12-12T17:46:33Z

@alan910127 Just wanted to tell you that it's fixed for me, it only generates one comment. Sorry for being so late to respond, honestly I forgot about it.

maxkarkowski · 2023-12-15T14:44:15Z

@alan910127 Just wanted to tell you that it's fixed for me, it only generates one comment. Sorry for being so late to respond, honestly I forgot about it.

that is weird. can you maybe share what command you execute in your pipeline? i still get multiple comments :/

JounQin · 2023-12-15T14:49:40Z

@maxkarkowski Maybe you can help to use patch-package to add some logs for debugging? I don't have a GitLab CE v16.6.0 for debugging for you, sorry.

maxkarkowski · 2023-12-18T09:29:34Z

@maxkarkowski Maybe you can help to use patch-package to add some logs for debugging? I don't have a GitLab CE v16.6.0 for debugging for you, sorry.

what exactly should i do with patch package? run it before changesets-gitlab on my pipeline? i use pnpm so i can only use pnpm patch.

JounQin · 2023-12-18T10:19:07Z

what exactly should i do with patch package? run it before changesets-gitlab on my pipeline? i use pnpm so i can only use pnpm patch.

Thanks that you're willing to help for debugging.

You can try to patch node_modules/changesets-gitlab/lib/comment.js accordingly.

Mostly you should add some logs at the following:

changesets-gitlab/src/comment.ts

Lines 107 to 132 in 9c6e792

    
           const getNoteInfo = (api: Gitlab, mrIid: number | string) => 
        
             api.MergeRequestDiscussions.all(context.projectId, mrIid).then( 
        
               async discussions => { 
        
                 for (const discussion of discussions) { 
        
                   if (!discussion.notes) { 
        
                     continue 
        
                   } 
        
                   const username = await getUsername(api) 
        
                   const changesetBotNote = discussion.notes.find( 
        
                     note => 
        
                       note.author.username === username && 
        
                       // We need to ensure the note is generated by us, but we don't have an app bot like GitHub 
        
                       // @see https://github.com/apps/changeset-bot 
        
                       note.body.includes(generatedByBotNote), 
        
                   ) 
        
                   if (changesetBotNote) { 
        
                     return { 
        
                       discussionId: discussion.id, 
        
                       noteId: changesetBotNote.id, 
        
                     } 
        
                   } 
        
                 } 
        
               }, 
        
             )

So that we can check why the previous mr was not found.

After seeing api.MergeRequestDiscussions, I have a theory that it could be API changed between MR discussions vs notes.

close #145

alan910127 · 2023-12-19T06:37:56Z

@alan910127 If you're free, please help to review #156.

Seems like I'm too late, sorry about that 😅.

JounQin · 2023-12-19T06:43:14Z

@alan910127 Never mind. You can still help to review it to prevent unexpected regressions or bugs.

maxkarkowski · 2023-12-19T10:38:54Z

i am sorry to say it but i installed the newest version and still get multiple comments

JounQin · 2023-12-19T10:50:32Z

@maxkarkowski 🤣 Let's debug again.

maxkarkowski · 2023-12-19T10:52:50Z

@maxkarkowski 🤣 Let's debug again.

what can i do?

JounQin · 2023-12-19T10:56:42Z

@maxkarkowski As previous, add log at

changesets-gitlab/src/comment.ts

Lines 122 to 132 in 99d8c17

    
           const isChangesetBotNote = ( 
        
             note: DiscussionNoteSchema | NoteSchema, 
        
             username: string, 
        
             random?: boolean, 
        
           ) => 
        
             (note.author.username === username || 
        
               (random && 
        
                 note.author.username.match(RANDOM_BOT_NAME_PATTERN)?.[1] === username)) && 
        
             // We need to ensure the note is generated by us, but we don't have an app bot like GitHub 
        
             // @see https://github.com/apps/changeset-bot 
        
             note.body.includes(generatedByBotNote)

to check why the previous comment unrecognized.

maxkarkowski · 2023-12-19T11:00:48Z

@maxkarkowski As previous, add log at

changesets-gitlab/src/comment.ts

Lines 122 to 132 in 99d8c17

const isChangesetBotNote = (

note: DiscussionNoteSchema | NoteSchema,

username: string,

random?: boolean,

) =>

(note.author.username === username ||

(random &&

note.author.username.match(RANDOM_BOT_NAME_PATTERN)?.[1] === username)) &&

// We need to ensure the note is generated by us, but we don't have an app bot like GitHub

// @see https://github.com/apps/changeset-bot

note.body.includes(generatedByBotNote)

to check why the previous comment unrecognized.

if i use pnpm patch i pnly have the compiled js file. i'll try to add some console.logs

maxkarkowski · 2023-12-19T11:11:07Z

function isChangesetBotNote(note, username, random) {
  console.log("note", note);
  console.log("username", username);
  console.log("random", random);
  if (
    note.author.username === username ||
    (random &&
      note.author.username.match(RANDOM_BOT_NAME_PATTERN)?.[1] === username)
  ) {
    console.log(generatedByBotNote);
    console.log(username);
    note.body.includes(generatedByBotNote);
  } else {
    console.log("else block;");
  }
}

i added some console.logs like this. and the result is

note {
  id: 495260,
  type: 'DiscussionNote',
  body: '###  ⚠️  No Changeset found\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    "Merging this MR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**\n" +
    '\n' +
    '<details><summary>This MR includes no changesets</summary>\n' +
    '\n' +
    "  When changesets are added to this MR, you'll see the packages that this MR includes changesets for and the associated semver types\n" +
    '\n' +
    '</details>\n' +
    '\n' +
    '[Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add a changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/evil-lizards-doubt.md&file=---%0A%0A---%0A%0Afeat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:43:51.351Z',
  updated_at: '2023-12-19T10:43:51.351Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495262,
  type: null,
  body: 'marked this merge request as **draft**',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:44:35.198Z',
  updated_at: '2023-12-19T10:44:35.203Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495272,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>93b5cbba - feat: add changeset</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:50:42.500Z',
  updated_at: '2023-12-19T10:50:42.513Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495273,
  type: 'DiscussionNote',
  body: '###  🦋  Changeset detected\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    '**The changes in this MR will be included in the next version bump.**\n' +
    '\n' +
    '<details><summary>This MR includes changesets to release 1 package</summary>\n' +
    '\n' +
    '  | Name         | Type  |\n' +
    '| ------------ | ----- |\n' +
    '| custom-theme | Patch |\n' +
    '\n' +
    '</details>\n' +
    '\n' +
    'Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/bumpy-trains-tap.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:51:30.037Z',
  updated_at: '2023-12-19T10:51:30.037Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495280,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>e4876a45 - test: debug username</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:56:54.710Z',
  updated_at: '2023-12-19T10:56:54.714Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495281,
  type: 'DiscussionNote',
  body: '###  🦋  Changeset detected\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    '**The changes in this MR will be included in the next version bump.**\n' +
    '\n' +
    '<details><summary>This MR includes changesets to release 1 package</summary>\n' +
    '\n' +
    '  | Name         | Type  |\n' +
    '| ------------ | ----- |\n' +
    '| custom-theme | Patch |\n' +
    '\n' +
    '</details>\n' +
    '\n' +
    'Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/sixty-teams-warn.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:57:54.212Z',
  updated_at: '2023-12-19T10:57:54.212Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495283,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>f2dc6603 - feat: debug even more</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:59:36.752Z',
  updated_at: '2023-12-19T10:59:36.757Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495285,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>443c7a4c - test: debug</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T11:05:31.451Z',
  updated_at: '2023-12-19T11:05:31.454Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495260,
  type: 'DiscussionNote',
  body: '###  ⚠️  No Changeset found\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    "Merging this MR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**\n" +
    '\n' +
    '<details><summary>This MR includes no changesets</summary>\n' +
    '\n' +
    "  When changesets are added to this MR, you'll see the packages that this MR includes changesets for and the associated semver types\n" +
    '\n' +
    '</details>\n' +
    '\n' +
    '[Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add a changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/evil-lizards-doubt.md&file=---%0A%0A---%0A%0Afeat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:43:51.351Z',
  updated_at: '2023-12-19T10:43:51.351Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495262,
  type: null,
  body: 'marked this merge request as **draft**',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:44:35.198Z',
  updated_at: '2023-12-19T10:44:35.203Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495272,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>93b5cbba - feat: add changeset</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:50:42.500Z',
  updated_at: '2023-12-19T10:50:42.513Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495273,
  type: 'DiscussionNote',
  body: '###  🦋  Changeset detected\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    '**The changes in this MR will be included in the next version bump.**\n' +
    '\n' +
    '<details><summary>This MR includes changesets to release 1 package</summary>\n' +
    '\n' +
    '  | Name         | Type  |\n' +
    '| ------------ | ----- |\n' +
    '| custom-theme | Patch |\n' +
    '\n' +
    '</details>\n' +
    '\n' +
    'Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/bumpy-trains-tap.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:51:30.037Z',
  updated_at: '2023-12-19T10:51:30.037Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495280,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>e4876a45 - test: debug username</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:56:54.710Z',
  updated_at: '2023-12-19T10:56:54.714Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495281,
  type: 'DiscussionNote',
  body: '###  🦋  Changeset detected\n' +
    '\n' +
    'Latest commit: \n' +
    '\n' +
    '**The changes in this MR will be included in the next version bump.**\n' +
    '\n' +
    '<details><summary>This MR includes changesets to release 1 package</summary>\n' +
    '\n' +
    '  | Name         | Type  |\n' +
    '| ------------ | ----- |\n' +
    '| custom-theme | Patch |\n' +
    '\n' +
    '</details>\n' +
    '\n' +
    'Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).\n' +
    '\n' +
    "[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDURL/REDACTEDREPOPATH/-/new/test/changesets-gitlab-new-version?file_name=.changeset/sixty-teams-warn.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)\n" +
    '\n' +
    '__Generated By Changesets GitLab Bot__',
  attachment: null,
  author: {
    id: 768,
    username: 'group_114_bot_HASH',
    name: '****',
    state: 'active',
    locked: false,
    avatar_url: 'GRAVATARURL',
    web_url: 'https://REDACTEDURL/group_114_bot_HASH'
  },
  created_at: '2023-12-19T10:57:54.212Z',
  updated_at: '2023-12-19T10:57:54.212Z',
  system: false,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: true,
  resolved: false,
  resolved_by: null,
  resolved_at: null,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495283,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>f2dc6603 - feat: debug even more</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T10:59:36.752Z',
  updated_at: '2023-12-19T10:59:36.757Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;
note {
  id: 495285,
  type: null,
  body: 'added 1 commit\n' +
    '\n' +
    '<ul><li>443c7a4c - test: debug</li></ul>\n' +
    '\n' +
    '[Compare with previous version](/REDACTEDREPOPATH/-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)',
  attachment: null,
  author: {
    id: 99,
    username: 'max.karkowski',
    name: 'Karkowski, Max',
    state: 'active',
    locked: false,
    avatar_url: 'https://secure.gravatar.com/avatar/ce5c37b052e79f9fa048081386068c91?s=80&d=identicon',
    web_url: 'https://REDACTEDURL/max.karkowski'
  },
  created_at: '2023-12-19T11:05:31.451Z',
  updated_at: '2023-12-19T11:05:31.454Z',
  system: true,
  noteable_id: 52608,
  noteable_type: 'MergeRequest',
  project_id: 3136,
  resolvable: false,
  confidential: false,
  internal: false,
  noteable_iid: 482,
  commands_changes: {}
}
username group_114_bot2
random undefined
else block;

JounQin · 2023-12-19T11:16:11Z

group_114_bot_5c775e3447ee50f45b58355852330c78 vs group_114_bot2, I don't think we can handle it automatically, can you remove the env and try again?

maxkarkowski · 2023-12-19T11:19:20Z

so without a gitlab_user_name?

JounQin · 2023-12-19T11:22:23Z

yep

GITLAB_CI_USER_NAME # optional, username with accessibility to push, used in pairs of the above token (if it was personal access token). If not set read it from the Gitlab API

maxkarkowski · 2023-12-19T11:26:53Z

i altered the name to GITLAB_CI_USER_NAME_BKP . still got a new comment

maxkarkowski · 2023-12-19T11:33:58Z

noteauthorusername max.karkowski
note.body marked this merge request as **draft**
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>93b5cbba - feat: add changeset</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>e4876a45 - test: debug username</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f2dc6603 - feat: debug even more</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>443c7a4c - test: debug</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f245f74a - feat: alter changeset</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291461&start_sha=443c7a4c6152c61b43f91e0ca242d00cc304d2e8)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>9a6b30ca - feat: new console.logs</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291464&start_sha=f245f74a21ced2f2ed04c0921d1ccd5f47ae9347)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body marked this merge request as **draft**
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>93b5cbba - feat: add changeset</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>e4876a45 - test: debug username</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f2dc6603 - feat: debug even more</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>443c7a4c - test: debug</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f245f74a - feat: alter changeset</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291461&start_sha=443c7a4c6152c61b43f91e0ca242d00cc304d2e8)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>9a6b30ca - feat: new console.logs</li></ul>
[Compare with previous version](/REDDACTEDPATH-/merge_requests/482/diffs?diff_id=291464&start_sha=f245f74a21ced2f2ed04c0921d1ccd5f47ae9347)
username group_114_bot_HASH
random undefined
else block;

and the next commit

noteauthorusername max.karkowski
note.body marked this merge request as **draft**
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>93b5cbba - feat: add changeset</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>e4876a45 - test: debug username</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f2dc6603 - feat: debug even more</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>443c7a4c - test: debug</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f245f74a - feat: alter changeset</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291461&start_sha=443c7a4c6152c61b43f91e0ca242d00cc304d2e8)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>9a6b30ca - feat: new console.logs</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291464&start_sha=f245f74a21ced2f2ed04c0921d1ccd5f47ae9347)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername group_114_bot_HASH
note.body ###  🦋  Changeset detected
Latest commit: 
**The changes in this MR will be included in the next version bump.**
<details><summary>This MR includes changesets to release 1 package</summary>
  | Name         | Type  |
| ------------ | ----- |
| custom-theme | Patch |
</details>
Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).
[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDREDACTED-/new/test/changesets-gitlab-new-version?file_name=.changeset/lucky-memes-invent.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)
__Generated By Changesets GitLab Bot__
username group_114_bot_HASH
random undefined
Generated By Changesets GitLab Bot
group_114_bot_HASH
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>cc894f9d - feat: add another word</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291466&start_sha=9a6b30ca65b0803684ddc68f9ca4d793de4b5a6a)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body marked this merge request as **draft**
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>93b5cbba - feat: add changeset</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291444&start_sha=aa97a9058a48bbe321f66b111dc726111a426a89)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>e4876a45 - test: debug username</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291450&start_sha=93b5cbba2e3f7129e991640caa0c028d630f83dd)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f2dc6603 - feat: debug even more</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291452&start_sha=e4876a4562f02af2f7e81aee6643bb744debeb23)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>443c7a4c - test: debug</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291458&start_sha=f2dc66035c4930cfa2c048cb3a09464f5f4eccc2)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>f245f74a - feat: alter changeset</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291461&start_sha=443c7a4c6152c61b43f91e0ca242d00cc304d2e8)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>9a6b30ca - feat: new console.logs</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291464&start_sha=f245f74a21ced2f2ed04c0921d1ccd5f47ae9347)
username group_114_bot_HASH
random undefined
else block;
noteauthorusername group_114_bot_HASH
note.body ###  🦋  Changeset detected
Latest commit: 
**The changes in this MR will be included in the next version bump.**
<details><summary>This MR includes changesets to release 1 package</summary>
  | Name         | Type  |
| ------------ | ----- |
| custom-theme | Patch |
</details>
Not sure what this means? [Click here  to learn what changesets are](https://github.com/changesets/changesets/blob/master/docs/adding-a-changeset.md).
[Click here if you're a maintainer who wants to add another changeset to this MR](https://REDACTEDREDACTED-/new/test/changesets-gitlab-new-version?file_name=.changeset/lucky-memes-invent.md&file=---%0A%0A---%0A%0ADraft%3A%20feat%3A%20update%20changesets-gitlab%0A)
__Generated By Changesets GitLab Bot__
username group_114_bot_HASH
random undefined
Generated By Changesets GitLab Bot
group_114_bot_HASH
noteauthorusername max.karkowski
note.body added 1 commit
<ul><li>cc894f9d - feat: add another word</li></ul>
[Compare with previous version](REDACTED-/merge_requests/482/diffs?diff_id=291466&start_sha=9a6b30ca65b0803684ddc68f9ca4d793de4b5a6a)
username group_114_bot_HASH
random undefined
else block;

JounQin · 2023-12-19T11:45:31Z

@maxkarkowski You'd better to log note.author.username, username at the same time outside, instead of in the if condition.

maxkarkowski · 2023-12-19T12:19:16Z

@maxkarkowski You'd better to log note.author.username, username at the same time outside, instead of in the if condition.

function isChangesetBotNote(note, username, random) {
  console.log("noteauthorusername", note.author.username);
  console.log("username", username);
  if (
    note.author.username === username ||
    (random &&
      note.author.username.match(RANDOM_BOT_NAME_PATTERN)?.[1] === username)
  ) {
    note.body.includes(generatedByBotNote);
  } else {
    console.log("else block;");
  }
}

result -->

noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot_random-hash
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot_random-hash
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
getNoteInfo username group_114_bot_random-hash
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot_random-hash
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot_random-hash
noteauthorusername max.karkowski
username group_114_bot_random-hash
else block;

and again with GITLAB_CI_USER_NAME (just to test it)

getNoteInfo username group_114_bot2
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
getNoteInfo username group_114_bot2
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername group_114_bot_random-hash
username group_114_bot2
note.body.includes(generatedByBotNote) true
else block;
noteauthorusername max.karkowski
username group_114_bot2
note.body.includes(generatedByBotNote) false
else block;

JounQin · 2023-12-19T13:03:24Z

noteauthorusername group_114_bot_random-hash
username group_114_bot_random-hash

Shouldn't this match? It seems you didn't return the result?

maxkarkowski · 2023-12-19T13:04:43Z

``` noteauthorusername group_114_bot_random-hash username group_114_bot_random-hash ```
Shouldn't this match? It seems you didn't return the result?

what do you mean exactly?

JounQin · 2023-12-19T13:06:28Z

@maxkarkowski

- note.body.includes(generatedByBotNote);
+ return note.body.includes(generatedByBotNote);

maxkarkowski · 2023-12-19T13:09:43Z

@maxkarkowski

- note.body.includes(generatedByBotNote);
+ return note.body.includes(generatedByBotNote);

is this an bug i added by rewriting the function? :D

JounQin · 2023-12-19T13:13:54Z

is this an bug i added by rewriting the function? :D

Yes, isChangesetBotNote is an arrow function previously, and you changed it into a regular function without return expression.

maxkarkowski · 2023-12-19T13:16:59Z

is this an bug i added by rewriting the function? :D

Yes, isChangesetBotNote is an arrow function previously, and you changed it into a regular function without return expression.

damn it. okay. i now created a new MR in my repo with the newest version of changesets-gitlab. and i altered the gitlab_ci_user_name to the group_114_bot_random-hash user. now i will give it another try

JounQin · 2023-12-19T13:18:16Z

You just need to remove gitlab_ci_user_name environment, or use group_114_bot instead of group_114_bot2 which does not match the token.

maxkarkowski · 2023-12-19T13:22:57Z

You just need to remove gitlab_ci_user_name environment, or use group_114_bot instead of group_114_bot2 which does not match the token.

now it works. sorry for the inconvience. but also thanks for your quick response and your help debugging it.

JounQin · 2023-12-19T13:28:06Z

OK, we can finally close this issue, right?

It's still worth to add a section of doc to describe this issue when using with bot username.

alan910127 mentioned this issue Dec 4, 2023

fix: keeps commenting on every push #153

Merged

JounQin closed this as completed in #153 Dec 4, 2023

JounQin added a commit that referenced this issue Dec 4, 2023

fix: keeps commenting on every push (#153)

b687dd8

close #145 --------- Co-authored-by: JounQin <[email protected]>

github-actions bot mentioned this issue Dec 4, 2023

chore: release package(s) #154

Merged

JounQin reopened this Dec 5, 2023

JounQin added a commit that referenced this issue Dec 18, 2023

fix: use discussion or note API accordingly

569933f

close #145

JounQin closed this as completed in #156 Dec 19, 2023

JounQin added a commit that referenced this issue Dec 19, 2023

fix: comment username could be random (#156)

3826317

close #145

github-actions bot mentioned this issue Dec 19, 2023

chore: release package(s) #157

Merged

JounQin reopened this Dec 19, 2023

JounQin mentioned this issue Apr 9, 2024

npx changesets-gitlab - git fetch origin main - unable to access URL using bad/illegal format or missing URL #116

Open

JounQin mentioned this issue Sep 14, 2024

changesets-gitlab comment logs Gitlab deprecation warning #187

Open

comment adds new comment with every commit #145

comment adds new comment with every commit #145

Comments

maxkarkowski commented Nov 27, 2023

JounQin commented Nov 27, 2023 • edited Loading

alan910127 commented Nov 27, 2023

maxkarkowski commented Nov 28, 2023 • edited Loading

maxkarkowski commented Nov 28, 2023

maxkarkowski commented Nov 28, 2023

alan910127 commented Nov 29, 2023

idumancic commented Nov 29, 2023

maxkarkowski commented Nov 29, 2023

maxkarkowski commented Nov 29, 2023

alan910127 commented Nov 30, 2023

maxkarkowski commented Nov 30, 2023

JounQin commented Dec 4, 2023 • edited Loading

alan910127 commented Dec 4, 2023 • edited Loading

alan910127 commented Dec 4, 2023

maxkarkowski commented Dec 5, 2023 • edited Loading

JounQin commented Dec 5, 2023

maxkarkowski commented Dec 5, 2023

alan910127 commented Dec 6, 2023 • edited Loading

maxkarkowski commented Dec 6, 2023

idumancic commented Dec 12, 2023

maxkarkowski commented Dec 15, 2023

JounQin commented Dec 15, 2023

maxkarkowski commented Dec 18, 2023 • edited Loading

JounQin commented Dec 18, 2023

alan910127 commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023 • edited Loading

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023 • edited Loading

maxkarkowski commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023 • edited Loading

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023 • edited Loading

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023

maxkarkowski commented Dec 19, 2023

JounQin commented Dec 19, 2023 • edited Loading

JounQin commented Nov 27, 2023 •

edited

Loading

maxkarkowski commented Nov 28, 2023 •

edited

Loading

JounQin commented Dec 4, 2023 •

edited

Loading

alan910127 commented Dec 4, 2023 •

edited

Loading

maxkarkowski commented Dec 5, 2023 •

edited

Loading

alan910127 commented Dec 6, 2023 •

edited

Loading

maxkarkowski commented Dec 18, 2023 •

edited

Loading

maxkarkowski commented Dec 19, 2023 •

edited

Loading

JounQin commented Dec 19, 2023 •

edited

Loading

maxkarkowski commented Dec 19, 2023 •

edited

Loading

maxkarkowski commented Dec 19, 2023 •

edited

Loading

JounQin commented Dec 19, 2023 •

edited

Loading