Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to start a discussion if no changeset is found, and a note if changeset is present #190

Open
utix opened this issue Jul 22, 2024 · 1 comment · May be fixed by #191
Open

I would like to start a discussion if no changeset is found, and a note if changeset is present #190

utix opened this issue Jul 22, 2024 · 1 comment · May be fixed by #191

Comments

@utix
Copy link

utix commented Jul 22, 2024

Hi,

I would like to propose a feature about comment type.
With GITLAB_COMMENT_TYPE we can set it to discussion or note.
When a changeset is missing I would like to have a discussion to block merge request without resolution of the discussion.
If one is set a simple note is ok

I propose to add an optional configuration GITLAB_COMMENT_TYPE_IF_MISSING to allow this behaviour.

If it is ok I will create a PR with this modification

utix added a commit to Neat-eu/changesets-gitlab that referenced this issue Jul 22, 2024
@Filipoliko
Copy link

We were discussing very similar topic in our company. We wanted to add the necessity to resolve the discussion if changeset is missing, but if the changeset was available, no resolution should be needed.

I think, that maybe a nicer approach about this could be resolving the discussion if changeset file is part of the MR and unresolving it if it is not. There is an exposed API to manipulate the resolution state of a discussion thread.

For more context... we configured our gitlab projects to make unresolved discussions in MR block the merge button. This helped us not to forget about missing changeset files, but became a bit of an annoyance for those who are not forgetting, but still have to resolve the discussion all the time before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants