From a96fcfd009b95d05f7e7bafb60ff35bf4653d832 Mon Sep 17 00:00:00 2001 From: JounQin Date: Tue, 26 Dec 2023 00:45:25 +0800 Subject: [PATCH] test: stick on Node v18.18 related https://github.com/privatenumber/tsx/issues/354 --- .github/workflows/ci.yml | 1 + test/helpers.ts | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 39c2dc6e7..f48b0f901 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,7 @@ jobs: node: - 16 - 18 + - 18.18 - 20 os: - macos-latest diff --git a/test/helpers.ts b/test/helpers.ts index ac197def9..086922403 100644 --- a/test/helpers.ts +++ b/test/helpers.ts @@ -8,8 +8,8 @@ export const _dirname = path.dirname(fileURLToPath(import.meta.url)) export const nodeVersion = Number.parseFloat(process.versions.node) export const tsUseEsmSupported = - nodeVersion >= MTS_SUPPORTED_NODE_VERSION && - // ts-jest limitation - nodeVersion < 20 + // https://github.com/privatenumber/tsx/issues/354 + // eslint-disable-next-line @typescript-eslint/no-magic-numbers + nodeVersion >= MTS_SUPPORTED_NODE_VERSION && nodeVersion <= 18.18 export const testIf = (condition: boolean) => (condition ? it : it.skip)