Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor or remove the management of crond #16

Open
trlinkin opened this issue Jun 25, 2014 · 0 comments
Open

Refactor or remove the management of crond #16

trlinkin opened this issue Jun 25, 2014 · 0 comments

Comments

@trlinkin
Copy link

I would argue that adding a crond service resource (in response to #7) to this module may not be the best the best thing.

You should/could either...
A) make it controlled via parameter
B) at least attempt to see if has been defined somewhere and not maybe not manage it here if so, using the "defined()" parser function

Personally, I think this is best handled with roles/profiles, allowing the dependency to be defined at that level if needed. Right now, with that cron resource, this module is managing resources that belong to another technology (cron). That makes it potentially hard to use some other module that explicitly is about managing cron for example.

Just some food for thought, perhaps a refactor should come from this. Otherwise awesome and well thought out module, thanks!

Ginja added a commit to sfu-rcg/sssd that referenced this issue Dec 1, 2014
In response to reading unbc#16, I've added
a new parameter that will control whether or not cron restarts when sssd does.
Ginja added a commit to sfu-rcg/sssd that referenced this issue Dec 1, 2014
In response to reading unbc#16, I've added
a new parameter that will control whether or not cron restarts when sssd does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant