Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in countCommitsSince(branchPoint(...)) #5

Open
oliver-brm opened this issue May 18, 2022 · 0 comments
Open

NPE in countCommitsSince(branchPoint(...)) #5

oliver-brm opened this issue May 18, 2022 · 0 comments

Comments

@oliver-brm
Copy link

Actual behavior:
The branchPoint("unknown") returns null if the specified branch point does not exist (or is not found). Therefore, countCommitsSince(branchPoint("unknown")) may throw a NullPointerException because it currently does not check for null.

Expected behavior:
countCommitsSince should check if the incoming value of obj is null and return -1 if so.

I've provided a fix in Pull Request #4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant