Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS sourcemaps #11

Closed
backflip opened this issue Nov 1, 2016 · 5 comments
Closed

Fix CSS sourcemaps #11

backflip opened this issue Nov 1, 2016 · 5 comments

Comments

@backflip
Copy link
Collaborator

backflip commented Nov 1, 2016

CSS sourcemaps are broken after the update to Node 6.

Example: When inspecting the "prev" button on http://unic.github.io/estatico/demo/modules/slideshow/slideshow.html, the line number for _slideshow.scss is 1 while it should rather be something between 24 and 38: https://github.com/unic/estatico/blob/develop/source/demo/modules/slideshow/slideshow.scss#L24-L41

Working (before update):
image

Nor Working (after update):
image

I wasn't able to find a working combination of gulp-sass and node-sass running on 6.7.0. Switching from gulp-autoprefixer to gulp-postcss and autoprefixer at least made sure that the correct files are shown (and should make it easier to add additional post-processing steps in the future), but I could not fix the line numbers.

Further reading: dlmanning/gulp-sass#354
@backflip
Copy link
Collaborator Author

backflip commented Nov 3, 2016

Probably related: postcss/postcss#814 (and mozilla/source-map#242 in consequence)

@backflip
Copy link
Collaborator Author

backflip commented Nov 3, 2016

To be watched: sass/libsass#2216

@backflip
Copy link
Collaborator Author

backflip commented Nov 3, 2016

What was tested so far:

  • Effect of base option in gulp stream
  • Effect of outputStyle in node-sass
  • Effect of downgrading postcss, gulp-postcss, autoprefixer and combinations

orioltf pushed a commit that referenced this issue Mar 8, 2017
Merge pull request #11 in BUDC/concorel-frontend from feature/CONCORE…
b87af02 
…L-154-grid-tasks-frontend to develop

* commit '4804a101b1704ceb2314828f1e55bcb7cbbd2020':
  CONCOREL-154: Add fix for IE11 calc bug in shorthand flex attribute
  Safari flexbox bug fixed
  Conent width change
  Grid responsive styles
  Grid max width & description update
  QS forms update
  CONCOREL-154 Concordia Grid
@backflip
Copy link
Collaborator Author

backflip commented Apr 5, 2017 •
edited
Loading

Still no luck in a project where I updated gulp-sass, gulp-sourcemaps and gulp-autoprefixer (as well es replacing gulp-autoprefixer with gulp-postcss) to the latest versions (running on an old Estatico version on Node 0.12., though).

@backflip
Copy link
Collaborator Author

backflip commented Feb 11, 2018 •
edited
Loading

The new implementation seems to experience the same issue (latest stable Node, latest versions of gulp-sass, gulp-postcss and autoprefixer, respectively). I don't see a fix for this rather than stopping to nest selectors in the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@backflip