Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key to options_hash for email: plus_allowed #1294

Open
Hainish opened this issue Aug 29, 2014 · 2 comments
Open

Add key to options_hash for email: plus_allowed #1294

Hainish opened this issue Aug 29, 2014 · 2 comments

Comments

@Hainish
Copy link
Contributor

Hainish commented Aug 29, 2014

Technically, + is a valid character in the user string of an email address. However, some congressional form validators will reject such an email address at the point of submission. Concommitant with EFForg/phantom-of-the-capitol#45, we should add a key to the options_hash for email fields with a key of plus_allowed, and a boolean value. This should be assumed to be true by implementations, unless specified as false.

@j-ro
Copy link
Contributor

j-ro commented Jan 15, 2015

noting here that there are lots of weird validation rules we've hit on some fields. Like, some forms won't accept spaces or punctuation in name fields, so a name of "J. R." fails.

Not really sure what can be done about that. We don't have a lot that fail this way, but a small percentage. I guess maybe think about how to work in validation rules into the yaml schema, but maybe that's overboard.

@oregondean
Copy link

One solution is to advise the owner of the form that they have an unreasonably tight criteria on some of their fields ... and track their progress towards correcting their form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants