-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-open ticket for a member if that member's form is broken #589
Comments
I can't find the code I used to make those tickets originally. But the Github Issue API is pretty straightforward, especially with the github gem. |
I have a script for this that I'll put up once I clean it up a bit |
Here's where I am at on this right now: https://gist.github.com/akosednar/11073387 Everything works minus following the pagnination of Github Issues. For some reason the |
I am also debating forcing a form test for each a form test has not been done recently for each which wouldn't be hard to do (unless the form has a captcha) |
Ah very handy akosednar, thanks! Question: how do we judge when a rep is actually failing? For example, it could just be wrong zip+4, etc, depending on each person's implementation. In the least, perhaps a certain percentage should be failing? Perhaps a central place to view all the stats from each implementation makes sense? Then we could use that to judge whether we deem something broken or not. |
I right now take the last test and use it's status to deem if it's failing or not. I want to rewrite the status checker and use the same code legind is using in the rails for the badges to decide if it's succeeding or not. Basically in the last X amount of days has more than a certain threshold failed. The homepage of the project kinda already gives the status of each form percentage wise for passing so it's the central stats page. However, I wanted to add the ability for this script to run the form test if it hadn't been ran in the last X days which I think is more useful Sent from my iPhone
|
Here's an endpoint you might find handy :). On Sat, Apr 19, 2014 at 11:37 AM, Anthony Kosednar <[email protected]
|
Yep! That's the one I use pretty much On Saturday, April 19, 2014, Sina Khanifar [email protected] wrote:
Sent from Gmail Mobile |
Oh damn, and I thought I was giving you something novel :). That makes On Sat, Apr 19, 2014 at 1:45 PM, Anthony Kosednar
|
Yep.I also have a setting for ignoring already open issues so if an issue is open it can ignore it and not close it (because it will assume the human knows better). I guess I'll add in that percentage check unless you don't think this should be persued further |
As reported by anyone integrated the data. The logic from an integrator should be - if it's closed, re-open it. If it's open, do nothing (I imagine Github will silently ignore a re-re-open request anyway).
The text was updated successfully, but these errors were encountered: