Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux for ninja and dotnet checkups #208

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ramezgerges
Copy link

No description provided.

@ramezgerges ramezgerges marked this pull request as ready for review December 2, 2023 22:02
@ramezgerges ramezgerges force-pushed the fix_linux branch 4 times, most recently from 541b793 to baab7d6 Compare December 7, 2023 10:56
@ramezgerges
Copy link
Author

ramezgerges commented Jan 31, 2024

@jeromelaban I came around to this PR and finally found the problem. We were using the pre-existing dotnet installation (net3.0 in CI I think) instead of the newly installed version (net8) to search for and install the templates. Linux and macOS are now passing, but Windows is giving me

Failed to load the dll from [C:\Program Files (x86)\dotnet\host\fxr\8.0.1\hostfxr.dll], HRESULT: 0x800700C1
The library hostfxr.dll was found, but loading it from C:\Program Files (x86)\dotnet\host\fxr\8.0.1\hostfxr.dll failed
  - Installing .NET prerequisites might help resolve this problem.
     https://go.microsoft.com/fwlink/?linkid=798306

It's highly unlikely that this PR had something to do with that, so could you take a look? Might this be about CI's windows version being below the minimum needed for net8?

@jeromelaban
Copy link
Member

@ramezgerges it's likely that this PR is causing this issue, as the very recent PRs from two days ago don't have this issue. We'll have to look again at the code executed for the .NET installation on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants