NGFW-14795 : password encryption feature #872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AristaKB
requested review from
DhirajM09,
mayur-dhande,
VarshaKache,
ShubhamJambhale-arista and
singhrohit23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Utility method to encrypt and decrypt password using binary.
*************************** NOTE ***************************
* Currently binary is generating warn related to TPM including the password in second line
* so handled the code accordingly in getEncryptPassword() and getDecryptPassword()
* Also while executing the command password is shown in log, I handled this by overriding rhe execOutput()
* and sending the value as false so you will not see any cmd log for password encryption and decryption
* To get it in log for debug purpose you can set the value as true