Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kaessert committed Oct 9, 2024
1 parent 550b284 commit 327aee4
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 1 deletion.
30 changes: 30 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,34 @@
# Usage
# ====================================================================================
# Generic Makefile to be used across repositories building a crossplane configuration
# package
#
# Available targets:
#
# - `yamllint`
# Runs yamllint for all files in `api`-folder recursively
#
# - `render`
# Runs crossplane render to render the output of the composition. Usefule for quick
# feedback in order to test templating.
# Important note:
# Claims need following annotations in order for render to work (adjust the paths
# if necessary):
# render.crossplane.io/composition-path: apis/pat/composition.yaml
# render.crossplane.io/function-path: examples/functions.yaml
#
# - `e2e`
# Runs full end-to-end test, including creating cluster, setting up the configuration
# and testing if create, import and delete work as expected.
# Available options:
# SKIP_DELETE (default `false`) skips the deletion of any resources created during the test
# SKIP_UPDATE (default `false`) skips testing the update of the claims
# SKIP_IMPORT (default `true`) skips testing the import of resources
# Example:
# `make e2e SKIP_DELETE=true`

# Project Setup
# ====================================================================================

# Include project.mk for project specific settings
include project.mk
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/app-claim.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: platform.upbound.io/v1alpha1
kind: App
metadata:
annotations:
render.crossplane.io/composition-path: apis/composition.yaml
render.crossplane.io/composition-path: apis/pat/composition.yaml
render.crossplane.io/function-path: examples/functions.yaml
name: configuration-app
namespace: default
Expand Down

0 comments on commit 327aee4

Please sign in to comment.