Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup yaml lint and local render target #7

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 4, 2024

Description of your changes

  • config
  • make target
  • github action
  • render target

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Before the indentation fixes

make yamllint
11:01:56 [ .. ] running yamllint
./apis/definition.yaml
  15:3      error    wrong indentation: expected 4 but found 2  (indentation)
  68:17     error    wrong indentation: expected 18 but found 16  (indentation)

11:01:56 [FAIL]
make: *** [Makefile:75: yamllint] Error 1
make render
make render
crossplane beta render examples/app-claim.yaml apis/composition.yaml examples/functions.yaml -r
---
apiVersion: platform.upbound.io/v1alpha1
kind: App
metadata:
  name: configuration-app
---
apiVersion: helm.crossplane.io/v1beta1
kind: Release
... 

* config
* make target
* github action
* render target

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

@ytsarev ytsarev requested a review from a team January 4, 2024 16:00
@ytsarev ytsarev merged commit 6e950c7 into upbound:main Jan 4, 2024
2 checks passed
@ytsarev ytsarev deleted the yamllint branch January 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants