References for intermediate ca creation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2024 08:51
…ermediate ca certificate to a pki backend Signed-off-by: Tobias Schlaepfer <[email protected]>
Signed-off-by: Tobias Schlaepfer <[email protected]>
|
@tschlaepfer apologies for the delay in getting to this. If you're still interested in pushing this PR forward, would you mind rebasing this PR to resolve conflicts and validate it now that we've released v2.0.0 of the provider. |
|
@jeanduplessis Yes I'm happy to move this PR forward. However, I would need #50 to be merged first as I run into the same issue in my setup. |
|
@tschlaepfer #50 merged just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change introduces a new reference parameter for the SecretBackendRootSignIntermediate and SecretBackendIntermediateSetSigned objects which enables the creation of a CA certificate chain using the HashiCorp Vault provider.
For the SecretBackendRootSignIntermediate object, the new parameter allows to reference a SecretBackendIntermediateCertRequest object, from which the "csr" parameter is fetched.
For the SecretBackendIntermediateSetSigned object, the new parameter allows to reference a SecretBackendIntermediateSetSigned object, from which the "certificate" parameter is fetched.
The MR also includes an example of creating a CA chain using the new reference parameters.
I have:
make reviewable testto ensure this PR is ready for review. -> But failed with golangci-lint error: panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmtHow has this code been tested
I ran the provider locally against my k8s cluster, where I deployed the ca-chain.yaml example provided in the MR. The code works as expected, I've attached two screenshots from the SecretBackendRootSignIntermediate & SecretBackendIntermediateSetSigned objects using the new csrRef and certificateRef parameters.