Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx: 2-part sign and send flow not necessary? #1055

Open
tomholford opened this issue Oct 13, 2022 · 0 comments
Open

tx: 2-part sign and send flow not necessary? #1055

tomholford opened this issue Oct 13, 2022 · 0 comments

Comments

@tomholford
Copy link
Collaborator

Currently for L1 transactions, there is a 2-step sign and send flow: eth_signTransaction and eth_sendTransaction (see: useEthereumTransaction.js). This appears to be flaky for some integrations of Walletconnect. Also it appears that the Ethereum community as a whole has settled on using the one-step eth_sendTransaction. This would simplify Bridge's TX flow, and potentially avoid bugs such as #1006 and #1035

Something we should investigate and potentially refactor when giving Bridge some TLC in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomholford