Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 adoptions should be performed on L1 #1128

Open
shawntobin opened this issue Oct 25, 2023 · 1 comment
Open

L1 adoptions should be performed on L1 #1128

shawntobin opened this issue Oct 25, 2023 · 1 comment
Assignees

Comments

@shawntobin
Copy link
Contributor

shawntobin commented Oct 25, 2023

Currently, if an L1 ship requests an escape then it's performed on L1. However, Bridge is set to only perform the adopt transaction on L2.

While this is valid behaviour for sponsorship actions, it's undesirable since it then creates stale information for "sponsor", "escape requested", and "escape requested to" on L1.

L2 will show the proper information, but it would be better to not mix L2 transactions when there's no benefit. Bridge should perform the adopt on L1 when the ship is L1, and L2 if it's on L2.

The L2 docs even state:

But, for instance, if both ~sampel-palnet and ~dopzod are on layer 1, it is technically possible for ~sampel-palnet to escape to ~dopzod on layer 1, and then ~dopzod can accept the escape on layer 2. This will result in ~dopzod appearing as the sponsor in the Layer 2 Azimuth state (and thus be ~sampel-palnet's "true" sponsor), and the sponsor in the Layer 1 Azimuth state will remain unchanged. While it is difficult to imagine a good reason to do this, developers working with layer 2 need to keep in mind these edge cases and ought to read on.

Yet we're creating these "edge cases" with every L1 escape performed via Bridge.

@shawntobin shawntobin self-assigned this Oct 25, 2023
@minderfolden
Copy link

My planet ~minder-folden is on L1. I tried to escape to my star that's on L2. I kept getting "execution reverted" error in MetaMask (connected to my Trezor where the planet lives). Is this issue the cause of the transaction not going through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants