Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the project and public APIs #2064

Merged
merged 55 commits into from
Jul 21, 2024
Merged

Restructure the project and public APIs #2064

merged 55 commits into from
Jul 21, 2024

Conversation

binrysearch
Copy link
Contributor

@binrysearch binrysearch commented Jul 13, 2024

The goal of this PR is to make the project modular and easier to maintain and update.

  • Refactors the project to be modular, with each part of the library added to ./packages (e.g. ./packages/tour)
  • Updates Cypress and Jest tests to be colocated within each package
  • Adds new Cypress commands to run the tests locally in a docker container

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
intro-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 11:46am

Copy link

github-actions bot commented Jul 13, 2024

Size Change: +3.91 kB (+10.95%) ⚠️

Total Size: 39.6 kB

Filename Size Change
dist/intro.js 14.4 kB +1.38 kB (+10.59%) ⚠️
dist/intro.module.js 10.8 kB +1.15 kB (+11.92%) ⚠️
dist/minified/intro.min.js 14.4 kB +1.38 kB (+10.59%) ⚠️

compressed-size-action

@binrysearch binrysearch requested a review from afshinm July 13, 2024 10:54
Copy link
Contributor

@afshinm afshinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We should refactor the tooltip package as well.

@binrysearch binrysearch merged commit 7399d37 into master Jul 21, 2024
5 checks passed
@binrysearch binrysearch deleted the restructure branch July 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants