Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure (JVM) API #348

Open
respatialized opened this issue Apr 13, 2022 · 5 comments
Open

Clojure (JVM) API #348

respatialized opened this issue Apr 13, 2022 · 5 comments

Comments

@respatialized
Copy link

Hi! After struggling a lot to grab some census data for a Clojure project, I eventually just grabbed the data using the tidycensus R package. But then I discovered this project!

I see that there was some discussion of a Clojure implementation over at #338. I would be interested in taking this on, and it seems like you've already got a solid foundation started with the .cljc namespaces. I decided to open a separate issue here to track this work, if I can be of assistance.

Please let me know what I can do to help!

@loganpowell
Copy link
Member

Hi @respatialized 👋 great to have your interest. I always wanted to publish this for the Clojure community but have zero experience publishing libs there. If you can help out, it would be greatly appreciated!

@respatialized
Copy link
Author

respatialized commented Apr 14, 2022

Ok, great! So a few questions/thoughts to get started:

  1. Looking under v2's source, the project doesn't have a deps.edn file for JVM dependencies and/or builds. Is this because this repo is a downstream product of another build/source? I think you mentioned this in the discussion of Ordering of geoHierarchy in Javascript object #338:

Let me know if so and I'll share the link to the subtree that feeds into this repo and powers the actual NPM package. That's where the Clojure code is isolated.

I'd appreciate you sharing that subtree so I can get a better sense of how the project is organized; I would like to get a working copy with a JVM repl on my own machine so I can explore the project interactively.

  1. If that subtree does have a deps.edn (or project.clj/lein) file, what specifically do you need help with in terms of publishing? Do you already have a build process that produces a jar, and you just need to get set up with Clojars, or do you need someone to work on a build process that produces maven-ready artifacts?

@loganpowell
Copy link
Member

loganpowell commented Apr 14, 2022

Hi @respatialized! Here is the subtree for CitySDK: https://github.com/loganpowell/census-geojson

That is the main repo. The v2 folder in this repo was used to (naively) archive the original, which was completely rewritten.

Regarding your second question: I actually don't know what I would need to publish a jar because I've never done it. Up until now, I've used shadow-cljs to package the program for NPM.

@respatialized
Copy link
Author

Hey @loganpowell - thanks for pointing me in the right direction. I got set up with the project yesterday evening and have begun working with the project from my REPL. I've already encountered a few issues along the way - I'll try to provide a more detailed overview of them relatively soon. Would it make more sense to create a separate issue over on the upstream repo to track those in detail?

@loganpowell
Copy link
Member

@respatialized we can track in the subtree if you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants