New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code QA suggestion for JarvisV4MintBridge.sol #19

Open

htadashi opened this issue May 5, 2022 · 0 comments

Contributor

htadashi commented May 5, 2022

These variables could be replaced by a constant variable in the contract:
https://github.com/defibasket/defibasket-contracts/blob/1e44ba96400a0a0f22279a975473e3e277507635/contracts/bridges/Jarvis/JarvisV4MintBridge.sol#L48

https://github.com/defibasket/defibasket-contracts/blob/1e44ba96400a0a0f22279a975473e3e277507635/contracts/bridges/Jarvis/JarvisV4MintBridge.sol#L90

Also, it would be nice to use _ to separate group of digits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment