Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for warnings and failures in the image build process based on image size #303

Open
seanhamlin opened this issue Mar 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@seanhamlin
Copy link
Contributor

seanhamlin commented Mar 8, 2024

At present, Lagoon will happily build a 5GiB docker image, push it to Harbor, and then when the pods schedule pull the image down the nodes. This can be problematic for

  • Pod scheduling (as it slows down k8s operations, waiting on image pulls)
  • Harbor - as getting huge images pushed and pulled from it is slow, and ties up resources
  • Developers - as they need to wait for longer periods of time for the above to occur

It would be good if we could use the new deployment warning system to allow:

  • Warnings - when the size of any single image is > X GiB. Where X is defined on a per cluster basis.
  • Failures - when the size of any single image is > Y GiB. Where Y is defined on a per cluster basis.

These could default to being unlimited (as in the current status quo) or extremely relaxed by default. Best practices for docker images could be developed as well, or you could link to something like https://www.pixelite.co.nz/article/dockerfile-best-practices/ ;)

@seanhamlin seanhamlin added the enhancement New feature or request label Mar 8, 2024
@bryangruneberg
Copy link

+1 on the approach @seanhamlin suggests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants