Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic #59

Open
shreddedbacon opened this issue Dec 26, 2023 · 1 comment · May be fixed by #60
Open

Don't panic #59

shreddedbacon opened this issue Dec 26, 2023 · 1 comment · May be fixed by #60

Comments

@shreddedbacon
Copy link
Member

We shouldn't panic in a reconcile loop, this results in issues with the controller crashing and blocking subsequent messages from being pulled from the queue. We should handle this more gracefully to prevent the controller crashing.

insights-handler/internal/handler/insightsParserFilter.go

Line 57 in 25cd127

panic(err)

insights-handler/internal/handler/insightsFactsParserFilter.go

Line 56 in 25cd127

panic("Can't unmarshal facts")

@shreddedbacon shreddedbacon linked a pull request Dec 26, 2023 that will close this issue
Draft
@bomoko
Copy link
Contributor

bomoko commented Jan 10, 2024 •
edited
Loading

Digging into the issue that was causing the crash, I think it might be related to this google/osv-scanner#733

@bomoko bomoko mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dont panic in processing, log the issue and move on uselagoon/insights-handler
2 participants
@bomoko @shreddedbacon